Skip to content

Port slonik-dataloaders #239

Port slonik-dataloaders

Port slonik-dataloaders #239

Triggered via pull request May 13, 2024 18:36
Status Failure
Total duration 2m 31s
Artifacts

feature.yaml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Test node_version:20 test_only:pg-integration
Process completed with exit code 1.
Test node_version:20 test_only:utilities
Process completed with exit code 1.
Lint: packages/sql-tag/src/factories/createSqlTag.test/sql.test.ts#L86
Unexpected 'todo' comment: 'TODO find a way to test this without...'
Lint: packages/driver/src/factories/createDriverFactory.ts#L427
Unexpected 'todo' comment: 'TODO determine if streaming and do not...'
Lint: packages/pg-driver/src/factories/createPgDriverFactory.ts#L185
Unexpected 'todo' comment: 'TODO evaluate if we can remove query...'
Lint: packages/slonik/src/factories/createConnectionPool.ts#L251
Unexpected 'todo' comment: 'TODO add pendingAcquireConnections'
Lint: packages/slonik/src/factories/createConnectionPool.ts#L252
Unexpected 'todo' comment: 'TODO add destroyedConnections'
Lint: packages/slonik/src/factories/createPool.ts#L26
Unexpected 'todo' comment: 'TODO resolve name conflict between...'
Lint: packages/slonik/src/helpers.test/createIntegrationTests.ts#L1260
Unexpected 'todo' comment: 'TODO why are we adding notices to a...'
Lint: packages/slonik-dataloaders/src/factories/createConnectionLoaderClass.ts#L243
Unexpected 'todo' comment: 'TODO add a test for this'
Lint: packages/slonik-interceptor-query-cache/src/utilities/extractCacheAttributes.ts#L21
Unexpected 'todo' comment: 'TODO throw an error if an unknown...'
Lint: packages/slonik-sql-tag-raw/src/factories/helpers.test/createTestRunner.ts#L4
Unexpected 'todo' comment: 'TODO deduplicate with...'