Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix deprecated deprecated argument #18119

Merged
merged 1 commit into from May 9, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 9, 2024

I broke that while merging forward #18105

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

I broke that while merging forward galaxyproject#18105
@github-actions github-actions bot added this to the 24.1 milestone May 9, 2024
@mvdbeek mvdbeek changed the title Fix deprecated deprecated argument [24.0] Fix deprecated deprecated argument May 9, 2024
@jdavcs jdavcs merged commit f2ddaa4 into galaxyproject:release_24.0 May 9, 2024
51 checks passed
@nsoranzo nsoranzo deleted the fix_deprecated_argument branch May 9, 2024 17:30
@nsoranzo
Copy link
Member

nsoranzo commented May 9, 2024

And we can go back to deprecated=True on dev 😆 , since it's been added in pydantic 2.7.0 ( pydantic/pydantic#8237 ).

@galaxyproject galaxyproject deleted a comment from github-actions bot May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants