improvement(api): send action type to cloud #5447
Draft
+87
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
from
48190b4
to
1178087
Compare
There's a bit of history here. Garden has a concept of action kinds and action types, both of which we want to store in display in the dashboard UI. Due to some legacy issues, were confusing the two and the API didn't support payload with the action type set correctly. This has since been fixed in the API but we never updated the Core payload until now. However, there are older instances of the API still running that haven't been updated to support this payload yet, so we feature flag it for now. We should be able to move the feature flag very soon.
eysi09
force-pushed
the
send-action-type-to-cloud-2
branch
from
1178087
to
4b5d7e2
Compare
eysi09
commented
Nov 21, 2023
| @@ -777,15 +777,29 @@ function dependenciesFromActionConfig( | |||
| const deps: ActionDependency[] = config.dependencies.map((d) => { | |||
| try { | |||
| const { kind, name } = parseActionReference(d) | |||
| return { kind, name, explicit: true, needsExecutedOutputs: false, needsStaticOutputs: false } | |||
| const depKey = actionReferenceToString(d) | |||
| const depConfig = configsByKey[depKey] | |||
There was a problem hiding this comment.
Just FYI @thsig, this won't work.
If the action depends on a module it won't be in that map and depConfig will be undefined.
That's why the CI tests are failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There's a bit of history here.
Garden has a concept of action kinds and action types, both of which we want to store in display in the dashboard UI.
Due to some legacy issues, were confusing the two and the API didn't support payload with the action type set correctly.
This has since been fixed in the API but we never updated the Core payload until now.
However, there are older instances of the API still running that haven't been updated to support this payload yet, so we feature flag it for now. We should be able to move the feature flag very soon.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: