feat: add config field and override param for require login #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhq
force-pushed
the
feature-optional-require-login
branch
from
5d492b7
to
35f59ef
Compare
mkhq
force-pushed
the
feature-optional-require-login
branch
2 times, most recently
from
c62e628
to
aa47f40
Compare
vvagaytsev
force-pushed
the
feature-optional-require-login
branch
from
1ea9aed
to
1c3690b
Compare
vvagaytsev
force-pushed
the
feature-optional-require-login
branch
from
1c3690b
to
146ed92
Compare
vvagaytsev
force-pushed
the
feature-optional-require-login
branch
from
146ed92
to
762e57d
Compare
vvagaytsev
force-pushed
the
feature-optional-require-login
branch
from
762e57d
to
799f9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This introduces a new Project-level config parameter that can force users of a project to login via Garden Cloud when there is a connected cloud project. The main use case is when a team is using garden together with Garden Cloud and would like to make sure that all users are logged in. Since making this change would be breaking, we introduce a config field + an env. var,
GARDEN_REQUIRE_LOGIN_OVERRIDE, to override the config. The default value of the config field isfalse, which does not require the user to login. When transitioning to 0.14, we will make the default valuetrue. Note, when there is no cloud project configured through theid-field in the Project-level config, garden works as usual without cloud and enforced login.When the config contains
requireLogin: trueorGARDEN_REQUIRE_LOGIN_OVERRIDE=trueand a user is not logged in to their cloud instance, the user will be notified that they need to be logged in. See example below:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: