[WIP] fix(template): unescape escape templates when not doing partial resolution

[edvald]

No description provided.

[eysi09]

LGTM

[TimBeyer]

When I was trying to resolve this I had a few more test cases. Maybe it makes sense to check if those pass too?
I'm not sure they all make sense, for example the resolving strings within escaped strings, but I think the other cases all were causing issues that were somewhere deeper in the parser where it wouldn't recognize escaped things when embedded in a larger string.

  it("should allow nesting normal strings within escaped strings", () => {
    const res = resolveTemplateString("$${var.${foo}}", new TestContext({ foo: "yes" }), { unescape: true })
    expect(res).to.equal("${var.yes}")
  })

  it("should allow nesting escaped strings within normal strings", () => {
    const res = resolveTemplateString("${foo == 'yes' ? '$${bar}' : 'fail' }", new TestContext({ foo: "yes" }), { unescape: true })
    expect(res).to.equal("${bar}")
  })


  it.only("should escape things correctly", () => {
    const res = resolveTemplateString("$${env.TEST_ENV}", new TestContext({}), {
      unescape: true,
    })
    expect(res).to.equal("${env.TEST_ENV}")
  })

  it.only("should escape things correctly", () => {
    const res = resolveTemplateString("foo $${env.TEST_ENV} bar", new TestContext({}), {
      unescape: true,
    })
    expect(res).to.equal("foo ${env.TEST_ENV} bar")
  })

  it.only("should escape things correctly", () => {
    const res = resolveTemplateString("$${env:TEST_ENV}", new TestContext({}), {
      unescape: true,
    })
    expect(res).to.equal("${env:TEST_ENV}")
  })


  it.only("should escape things correctly", () => {
    const res = resolveTemplateString("foo $${env:TEST_ENV} bar", new TestContext({}), {
      unescape: true,
    })
    expect(res).to.equal("foo ${env:TEST_ENV} bar")
  })

  it("should escape things correctly", () => {
    const res = resolveTemplateString("${foo}-$${env:TEST_ENV}", new TestContext({ foo: "foo" }), {
      unescape: true,
    })
    expect(res).to.equal("foo-${env:TEST_ENV}")
  })

[eysi09]

@TimBeyer, yeah good catch.

Also, the framework tests appear to be failing.

[stefreak]

It's not really obvious to me how this fixes the end user issue – can we also add an integration test that shows how this fixes the issue in a less synthetic scenario?

[edvald]

All fair points, flagging as WIP for now.

Btw the microk8s test failures seem unrelated. Not sure if we've been seeing those as flaky?

Need to update the PR

[edvald]

@TimBeyer this isn't the current behavior, so it would be a breaking change:

it("should allow nesting normal strings within escaped strings", () => {
const res = resolveTemplateString("$${var.${foo}}", new TestContext({ foo: "yes" }), { unescape: true })
expect(res).to.equal("${var.yes}")
})