fix: garden publish command to respect publishId
#6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/publish-command
branch
2 times, most recently
from
28a354c
to
d50350e
Compare
To see more similarities between 2 handlers
vvagaytsev
force-pushed
the
fix/publish-command
branch
from
d50350e
to
c82ccad
Compare
The parsed image comes from a helper function. That helpers function uses `splitLast` instead of `splitFirst` with `:`-delimiter to get the tag name. That looks correct.
The only diff between `getContainerBuildActionOutputs` and `k8sGetContainerBuildActionOutputs` was in the deploymentImageId calculation that depended on the presence of deployment registry config.
vvagaytsev
force-pushed
the
fix/publish-command
branch
from
8b00ed8
to
5b30a72
Compare
Align the behaviour with the `k8sPublishContainerBuild` which does not compare local and remote images. The repeated tagging is idemponent and should not be too costly.
It was used only in one place.
Each in its own variable.
Publish ID is used only by `publish` command, and it should not be used for internal deployment registries and while Build-actions resolution.
vvagaytsev
force-pushed
the
fix/publish-command
branch
from
06a8198
to
6620d72
Compare
vvagaytsev
changed the title
garden publish commandgarden publish command to respect publishId
edvald
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the behavior of
garden publishcommand. See #6050 for additional context and technical details.Which issue(s) this PR fixes:
Fixes #6050 #5045 #4796
Reverts #4740
Reopens #4095
Patches #4808
Special notes for your reviewer:
This PR does not address possible Action Router problems mentioned in #6050. There might be no issues at all in the Action Router. That should be considered separately, and another PR can be created if any fix is required.