Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.90] Downgrade skaffold to v2.9.0 #9328

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented Mar 6, 2024

This is an automated cherry-pick of #9327

/assign ialidzhikov

The skaffold version is downgraded from v2.10.1 to v2.9.0 to fix an issue with skaffold not detecting code changes on `make gardener-up`.

@gardener-ci-robot gardener-ci-robot added the area/dev-productivity Developer productivity related (how to improve development) label Mar 6, 2024
@gardener-ci-robot gardener-ci-robot added the kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution label Mar 6, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@oliver-goetz
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

LGTM label has been added.

Git tree hash: a7cc46707c9e9f654b327eb891dd0e2f973ab71b

Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@gardener-prow gardener-prow bot merged commit fe41fbd into gardener:release-v1.90 Mar 6, 2024
16 checks passed
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-9327-to-release-v1.90 branch March 6, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants