Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade skaffold to v2.9.0 #9327

Merged

Conversation

dimityrmirchev
Copy link
Member

@dimityrmirchev dimityrmirchev commented Mar 6, 2024

How to categorize this PR?

/area dev-productivity
/kind regression

What this PR does / why we need it:
After #9237 and the upgrade of skaffold to v2.10.1 the local kind setup is not working as expected when changes are made to the codebase. This PR reverts the skaffold version.

To reproduce:

make kind-up
make gardener-up

Do a change to some code used in gardenlet (for example). Run make gardener-up again. I expect that the gardenlet image is rebuilt and deployed, but the output says

europe-docker.pkg.dev/gardener-project/releases/gardener/gardenlet: Found. Tagging

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

cc @ialidzhikov
Release note:

The skaffold version is downgraded from v2.10.1 to v2.9.0 to fix an issue with skaffold not detecting code changes on `make gardener-up`.

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I am able to reproduce the issue with skaffold@v2.10.1 and confirm that it does not exist with skaffold@v2.9.0

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

LGTM label has been added.

Git tree hash: b3d73068a9003f9b5810a8a1fc8da3cdb12012d8

Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@oliver-goetz
Copy link
Member

A fix seems to be merged already GoogleContainerTools/skaffold#9313, but there is no patch release which includes the fix yet.

@ialidzhikov
Copy link
Member

ialidzhikov commented Mar 6, 2024

A fix seems to be merged already GoogleContainerTools/skaffold#9313, but there is no patch release which includes the fix yet.

Ah, thanks. I was about to open a new issue and I spent the last hour preparing a dummy project and reproducing the issue there...

@ialidzhikov
Copy link
Member

/cherry-pick release-v1.90

@gardener-ci-robot
Copy link
Contributor

@ialidzhikov: once the present PR merges, I will cherry-pick it on top of release-v1.90 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov
Copy link
Member

#9327 (comment): as the skaffold version is used by several extensions (such as registry-cache, shoot-rsyslog-relp, and others).

@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Mar 6, 2024
@gardener-prow gardener-prow bot merged commit 130227c into gardener:master Mar 6, 2024
17 checks passed
@gardener-ci-robot
Copy link
Contributor

@ialidzhikov: new pull request created: #9328

In response to this:

/cherry-pick release-v1.90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants