-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade skaffold to v2.9.0 #9327
Downgrade skaffold to v2.9.0 #9327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I am able to reproduce the issue with skaffold@v2.10.1 and confirm that it does not exist with skaffold@v2.9.0
LGTM label has been added. Git tree hash: b3d73068a9003f9b5810a8a1fc8da3cdb12012d8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A fix seems to be merged already GoogleContainerTools/skaffold#9313, but there is no patch release which includes the fix yet. |
Ah, thanks. I was about to open a new issue and I spent the last hour preparing a dummy project and reproducing the issue there... |
/cherry-pick release-v1.90 |
@ialidzhikov: once the present PR merges, I will cherry-pick it on top of release-v1.90 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#9327 (comment): as the skaffold version is used by several extensions (such as registry-cache, shoot-rsyslog-relp, and others). |
@ialidzhikov: new pull request created: #9328 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How to categorize this PR?
/area dev-productivity
/kind regression
What this PR does / why we need it:
After #9237 and the upgrade of
skaffold
tov2.10.1
the local kind setup is not working as expected when changes are made to the codebase. This PR reverts theskaffold
version.To reproduce:
Do a change to some code used in
gardenlet
(for example). Runmake gardener-up
again. I expect that thegardenlet
image is rebuilt and deployed, but the output saysWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @ialidzhikov
Release note: