Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor github.com/gardener/controller-runtime@v0.6.3-gardener.1 #2876

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Sep 22, 2020

How to categorize this PR?

/area scalability robustness
/kind bug
/priority normal

What this PR does / why we need it:
With this PR we vendor a forked sigs.k8s.io/controller-runtime repository which includes the not-yet-merged improvement from @timebertt (kubernetes-sigs/controller-runtime#1151).

We also pass a custom rate limiter that allows one request every 5s as suggested in #2747 (comment).

Which issue(s) this PR fixes:
Fixes #2747
Fixes #2675

/invite @timebertt
/assign @timebertt

Release note:

NONE

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care!
This will also fix #2675.

Only one nit suggestion, otherwise /lgtm.

pkg/client/kubernetes/runtime_client.go Outdated Show resolved Hide resolved
Co-Authored-By: Max Becker <max.becker@sap.com>
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@rfranzke rfranzke merged commit 73c6adb into gardener:master Sep 23, 2020
@rfranzke rfranzke deleted the vendor/ctrlruntime-fork branch September 23, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/robustness Robustness, reliability, resilience related area/scalability Scalability related kind/bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gardenlet times out talking to the Seed API server Dynamic RESTMapper limited
6 participants