-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seed reconciler for secret replication #3582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
area/security
Security related
kind/enhancement
Enhancement, improvement, extension
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Feb 18, 2021
rfranzke
reviewed
Feb 18, 2021
timuthy
force-pushed
the
enhancement.seed-controller
branch
from
February 19, 2021 17:16
ce0203c
to
0124670
Compare
timebertt
reviewed
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question from my side.
Looks good overall :)
timebertt
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my suggestion.
Very nice!
/lgtm
gardener-robot
added
priority/3
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/security
Security related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR adds a new seed reconciler which:
seed-<seed-name>
gardener.cloud/role
label from thegarden
namespace toseed-<seed-name>
namespacesIn the future, this dedicated namespace will allow us to restrict Gardenlets to only access these namespaces (see #1723).
Which issue(s) this PR fixes:
Fixes parts of #1723
Special notes for your reviewer:
The seed lifecycle controller was refactored along the way and now implements the
reconcile.Reconciler
interface./cc @rfranzke
Release note: