Remove dependency injection functions #8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
gardener-prow
bot
added
do-not-merge/work-in-progress
gardener-prow
bot
added
the
size/XXL
|
/test all |
gardener-prow
bot
removed
the
do-not-merge/work-in-progress
ary1992
force-pushed
the
enh/inject-package
branch
from
08c5f68
to
aa855e7
Compare
ScheererJ
reviewed
Jul 7, 2023
shafeeqes
reviewed
Jul 7, 2023
extensions/pkg/controller/controlplane/genericactuator/actuator.go
Outdated
Show resolved
Hide resolved
|
/retest |
|
LGTM label has been added. Git tree hash: 7a09b7c7a77db56743ea2ffb8ab2bd70aba9da86
|
|
/assign |
timebertt
reviewed
Jul 10, 2023
extensions/pkg/controller/controlplane/genericactuator/actuator.go
Outdated
Show resolved
Hide resolved
timebertt
reviewed
Jul 10, 2023
…eRequestsFrom` function
timebertt
reviewed
Jul 11, 2023
|
|
||
| // ClientContext bundles the feature of providing injected scheme and client for | ||
| // the controller runtime. Additionally it offers a decoder using the scheme. | ||
| type ClientContext struct { |
There was a problem hiding this comment.
Can you mention/explain the removal of this package in the release note as well? :)
|
LGTM label has been added. Git tree hash: fa1059deb98598618b2d055d84c5568c55f22b9e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
nickytd
pushed a commit
to nickytd/gardener
that referenced
this pull request
Sep 11, 2023
* Adapt extensions/pkg/controller/backupBucket * Adapt extensions/pkg/controller/backupEntry * Adapt extensions/pkg/controller/containerruntime * Adapt extensions/pkg/controller/controlplane * Adapt extensions/pkg/controller/dnsrecord * Adapt extensions/pkg/controller/extension * Adapt extensions/pkg/controller/healthcheck * Adapt extensions/pkg/controller/network * Adapt extensions/pkg/controller/bastion * Adapt extensions/pkg/controller/infrastructure * Adapt extensions/pkg/controller/operatingsystemconfig * Adapt extensions/pkg/controller/controlplane * Adapt pkg/controllerutils/reconciler * Adapt extensions/pkg/controller/healthcheck * Adapt extensions/pkg/controller/heartbeat * Adapt extensions/pkg/controller/worker * Adapt provider-local * Add `context.Context` as first argument to AddToManager function * Adapt extensions/pkg/predicate/ * Adapt validator, handler and mutator * Adapt `ClientContext` for extensions controller * Adapt pkg/gardenlet/controller/controllerinstallation * Adapt pkg/gardenlet/controller/managedseed * Adapt pkg/controllermanager/controller/managedseedset * Adapt pkg/controllerutils/mapper * Adapt extensions/pkg/controller/mock/ * Adapt tests * [OperationAnnotationWrapper] Address PR review * Address PR review feedback * Drop pkg/controller/common * [Address PR review feedback] Pass cache instead of manager to `EnqueueRequestsFrom` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source dev-productivity
/kind enhancement
What this PR does / why we need it:
The package
controller-runtime/pkg/runtime/injecthas been removed incontroller-runtimev0.15. This package contained long deprecated injection functions (likeInjectScheme,InjectLogger,InjectConfig,InjectClient,InjectCache, etc.).The runtime injection functionality has been deprecated since
Controller Runtime 0.10; all of the above fields can be passed from theManagerto structs or interfaces that need them.kubernetes-sigs/controller-runtime#2134
kubernetes-sigs/controller-runtime#2120
Which issue(s) this PR fixes:
Part of #7991
Special notes for your reviewer:
Release note: