New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s.io/*
, sigs.k8s.io/controller-runtime
dependencies
#8666
Conversation
/cherry-pick release-v1.80 |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.80 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v1.81 |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.81 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v1.82 |
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.82 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now also remove TODO -
gardener/pkg/operation/botanist/kubeapiserver_test.go
Lines 556 to 570 in 743cc3e
// TODO(acumino): Enable this test again once https://github.com/kubernetes-sigs/controller-runtime/issues/2503 is fixed. | |
// Describe("#ScaleKubeAPIServerToOne", func() { | |
// deployment := &appsv1.Deployment{ObjectMeta: metav1.ObjectMeta{Name: "kube-apiserver", Namespace: seedNamespace}} | |
// It("should scale the KAPI deployment", func() { | |
// Expect(seedClient.Create(ctx, deployment)).To(Succeed()) | |
// Expect(seedClient.Get(ctx, client.ObjectKeyFromObject(deployment), deployment)).To(Succeed()) | |
// Expect(botanist.ScaleKubeAPIServerToOne(ctx)).To(Succeed()) | |
// Expect(seedClient.Get(ctx, client.ObjectKeyFromObject(deployment), deployment)).To(Succeed()) | |
// Expect(deployment.Spec.Replicas).To(Equal(pointer.Int32(1))) | |
// }) | |
// }) |
Issue was fixed with - kubernetes-sigs/controller-runtime#2508
/cla |
Successfully reached out to cla-assistant.io to initialize recheck of PR #8666 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
LGTM label has been added. Git tree hash: a3ab17876adcb5b9b90def3a2da3e15b4d940efd
|
Running the integration tests locally on my machine succeeds without any issues... not sure why it repeatedly fails in Prow/CI. |
b069dac
to
a6627e2
Compare
9d39759
to
e08fb2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: c80a7e86d1cd25d32d4b296a26550c576332eb89
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timuthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@rfranzke: #8666 failed to apply on top of branch "release-v1.80":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rfranzke: #8666 failed to apply on top of branch "release-v1.81":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rfranzke: new pull request created: #8677 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…igs.k8s.io/controller-runtime` dependencies (#8681) * Update `k8s.io/*`, `sigs.k8s.io/controller-runtime` * Address PR review feedback * WIP/DEBUG: Revert some change of k8s.io/apiserver * Ensure resources can be listed before GAPI is ready in envtest
…igs.k8s.io/controller-runtime` dependencies (#8680) * Update `k8s.io/*`, `sigs.k8s.io/controller-runtime` * Address PR review feedback * WIP/DEBUG: Revert some change of k8s.io/apiserver * Ensure resources can be listed before GAPI is ready in envtest
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
Update
k8s.io/*
,sigs.k8s.io/controller-runtime
dependencies to their latest patch versions.With this, GAPI also gets the new generic feature gate
UnauthenticatedHTTP2DOSMitigation
like KAPI, see #8665.Special notes for your reviewer:
/cc @timuthy
Release note: