Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-26] Add WorkloadIdentity API #9780

Merged
merged 12 commits into from
May 29, 2024
Merged

[GEP-26] Add WorkloadIdentity API #9780

merged 12 commits into from
May 29, 2024

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area security ipcei
/kind enhancement

What this PR does / why we need it:
Add the WorkloadIdentity API from GEP-26: Workload Identity - Trust Based Authentication

Which issue(s) this PR fixes:
Part of #9586

Special notes for your reviewer:

Release note:

@gardener-prow gardener-prow bot added area/security Security related area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 16, 2024
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 16, 2024
@vpnachev vpnachev mentioned this pull request May 16, 2024
Open
37 tasks
rfranzke
rfranzke requested changes May 21, 2024
View reviewed changes
example/70-workloadidentity-provider.yaml Outdated Show resolved Hide resolved
example/70-workloadidentity-provider.yaml Outdated Show resolved Hide resolved
pkg/apis/security/types_workloadidentity.go Outdated Show resolved Hide resolved
pkg/apis/security/validation/workloadidentity.go Outdated Show resolved Hide resolved
pkg/apis/security/validation/workloadidentity.go Show resolved Hide resolved
pkg/apiserver/registry/security/rest/storage_security.go Outdated Show resolved Hide resolved
pkg/apiserver/registry/security/workloadidentity/strategy.go Show resolved Hide resolved
pkg/apiserver/registry/security/workloadidentity/strategy_test.go Outdated Show resolved Hide resolved
pkg/apiserver/registry/security/workloadidentity/strategy_test.go Outdated Show resolved Hide resolved
pkg/apiserver/registry/security/workloadidentity/workloadidentity_suite_test.go Outdated Show resolved Hide resolved
@vpnachev vpnachev mentioned this pull request May 21, 2024
Open
@dimityrmirchev
Copy link
Member

/assign

dimityrmirchev
dimityrmirchev reviewed May 22, 2024
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and a few suggestions w.r.t. wording from my side

pkg/apis/security/types_workloadidentity.go Outdated Show resolved Hide resolved
pkg/apis/security/types_workloadidentity.go Outdated Show resolved Hide resolved
pkg/apis/security/types_workloadidentity.go Outdated Show resolved Hide resolved
pkg/apis/security/v1alpha1/types_workloadidentity.go Show resolved Hide resolved
pkg/apiserver/registry/security/workloadidentity/storage/tableconvertor.go Show resolved Hide resolved
@vpnachev
Copy link
Member Author

/label ipcei/workload-identity

@gardener-prow gardener-prow bot added the ipcei/workload-identity Epic for Gardener Workload Identity scenarios label May 22, 2024
@vpnachev vpnachev mentioned this pull request May 22, 2024
Merged
@vpnachev
Copy link
Member Author

/retest-required

rfranzke
rfranzke reviewed May 27, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall now 🚀

pkg/apis/security/v1alpha1/types_workloadidentity.go Outdated Show resolved Hide resolved
pkg/apis/security/validation/workloadidentity.go Outdated Show resolved Hide resolved
@dimityrmirchev
Copy link
Member

Thanks for addressing the suggestions! /lgtm from my side

@vpnachev
Copy link
Member Author

Excuse me for the delay, the comments are addressed now with c2f4f8b

@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 29, 2024

LGTM label has been added.

Git tree hash: b91c70295260d27ce0ee3e3cec7ead97622ba404

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@gardener-prow gardener-prow bot merged commit 64729fb into gardener:master May 29, 2024
18 checks passed
@vpnachev vpnachev deleted the gep26/workloadidentity-api branch May 29, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke requested changes

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@plkokanov plkokanov Awaiting requested review from plkokanov

@dimityrmirchev dimityrmirchev Awaiting requested review from dimityrmirchev

Assignees

@rfranzke rfranzke

@dimityrmirchev dimityrmirchev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. ipcei/workload-identity Epic for Gardener Workload Identity scenarios kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vpnachev @dimityrmirchev @rfranzke