-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move machine-controller-manager-provider-local
into gardener/gardener
#9782
Move machine-controller-manager-provider-local
into gardener/gardener
#9782
Conversation
7946b88
to
34f7c08
Compare
/retest |
/assign |
34f7c08
to
621ac85
Compare
Thanks for your review @plkokanov. I rebased and addressed your suggestions. |
621ac85
to
394a3e9
Compare
58faa01
to
d0841b0
Compare
d0841b0
to
f1e68e6
Compare
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
Image is always provided by the kind cluster config yaml. Hence, this `--image` flag never had any effect because it was always overwritten. Co-Authored-By: Rafael Franzke <rafael.franzke@sap.com> Co-Authored-By: Marcel Boehm <marcel.boehm@inovex.de>
f1e68e6
to
7ec12fe
Compare
/lgtm |
LGTM label has been added. Git tree hash: b4758f05ababcbfeb07d2edef73106e97d44a533
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
In order to improve development productivity, this PR moves the content of the https://github.com/gardener/machine-controller-manager-provider-local repository into
gardener/gardener
. The images are built dynamically with Skaffold and pushed into the local registry.On the way, we
skaffold.yaml
file (removing theeurope-docker.pkg.dev/*
prefixes since these images are never actually pushed to this real remote registrylogcheck
golangci-lint
plugin to prevent false positive findings in case a package-level functions disguises aslogr
methodRelease note: