Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm provider to support natgateway #35

Merged
merged 1 commit into from Mar 11, 2020

Conversation

dkistner
Copy link
Member

@dkistner dkistner commented Mar 10, 2020

What this PR does / why we need it:
Need to bump the azurerm to a version which support the Azure NatGateway.

There seems to be a bug, which affect the Azure Nat Gateway integration. See here: hashicorp/terraform-provider-azurerm#6052

Release note:

Update Terraform `azurerm` provider to support Azure NatGateway.

@dkistner dkistner requested a review from a team as a code owner March 10, 2020 15:07
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 10, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 11, 2020
@dkistner
Copy link
Member Author

As we introduce the Azure NatGateway with multiple steps, therefore we can go on for now with this version. The mentioned bug affect only the "bring your own ip for NatGateway" scenario, which we will be enabled with the second step of the NatGateway, see here: gardener/gardener-extension-provider-azure#43 (comment)

@dkistner dkistner changed the title [WIP] Update azurerm provider to support natgateway Update azurerm provider to support natgateway Mar 11, 2020
@rfranzke rfranzke merged commit 8919899 into gardener:master Mar 11, 2020
@dkistner dkistner deleted the update-azurerm-provider branch March 11, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants