fix: use nullish coalescing to check user configuration prior to defa…

…ult `misMatchThreshold` and `requireSameDimensions` values (#1557) (#1558)
garris · Mar 5, 2024 · d6a3abd · d6a3abd
1 parent a0a9507
commit d6a3abd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/util/engineTools.js b/core/util/engineTools.js
@@ -6,7 +6,7 @@
  * @returns {number} The mismatch threshold value.
  */
 function getMisMatchThreshHold (scenario, config) {
-  return scenario?.misMatchThreshold || config?.misMatchThreshold || config?.defaultMisMatchThreshold || 0.1;
+  return scenario?.misMatchThreshold ?? config?.misMatchThreshold ?? config?.defaultMisMatchThreshold ?? 0.1;
 }
 
 function ensureFileSuffix (filename, suffix) {
@@ -43,7 +43,7 @@ function genHash (str) {
  * @returns {boolean} True if the same dimensions are required, otherwise false.
  */
 function getRequireSameDimensions (scenario, config) {
-  return scenario?.requireSameDimensions || config?.requireSameDimensions || config?.defaultMisMatchThreshold || true;
+  return scenario?.requireSameDimensions ?? config?.requireSameDimensions ?? config?.defaultMisMatchThreshold ?? true;
 }
 
 function getSelectorName (selector) {