Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.1.0-beta #106

Merged
merged 21 commits into from Sep 4, 2022
Merged

v4.1.0-beta #106

merged 21 commits into from Sep 4, 2022

Conversation

garronej
Copy link
Owner

@garronej garronej commented Sep 4, 2022

Try out #105

@garronej garronej changed the title v4.1.0-beta.0 v4.1.0-beta Sep 4, 2022
garronej
garronej commented Sep 4, 2022
View reviewed changes
package.json
Comment on lines +12 to +27
"exports": {
".": {
"import": "./dist/esm/index.js"
},
"./mui": {
"import": "./dist/esm/mui.js"
},
"./nextJs": {
"import": "./dist/esm/nextJs.js"
},
"./compat": {
"import": "./dist/esm/compat.js"
},
"./mui_compat": {
"import": "./dist/esm/mui_compat.js"
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up removing "require" as I don't see the point of keeping them. Agree @jiby-aurum ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garronej unfortunately I think its required, I tried it 4.1.0 and it fails to import tss-react/mui complaining that it is not defined in exports, adding the "require" back fixes them.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiby-aurum Thank you for the feedback, I added it back in.
It's in 4.1.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again @garronej just tested, works perfectly !

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@garronej garronej merged commit 9cfd4a4 into main Sep 4, 2022
@garronej garronej deleted the cjs_esm branch September 4, 2022 17:10
garronej added a commit that referenced this pull request Sep 4, 2022
@garronej
https://github.com/garronej/tss-react/pull/106#discussion_r962373391
86dd464
@garronej garronej mentioned this pull request Sep 7, 2022
Closed
jiby-aurum
jiby-aurum reviewed Sep 7, 2022
View reviewed changes
tsconfig.json
@@ -1,9 +1,9 @@
{
"compilerOptions": {
"module": "CommonJS",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garronej this should not have been removed,

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad.
The default config is for CommonJS and we overwrite some values when building for ESM....

gastonfournier pushed a commit to Unleash/unleash that referenced this pull request Feb 15, 2023
@renovate
chore(deps): update dependency tss-react to v4.6.0 (#2377)
90bbbc3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tss-react](https://www.tss-react.dev)
([source](https://togithub.com/garronej/tss-react)) | [`4.0.0` ->
`4.6.0`](https://renovatebot.com/diffs/npm/tss-react/4.0.0/4.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/compatibility-slim/4.0.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/confidence-slim/4.0.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>garronej/tss-react</summary>

###
[`v4.6.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.6.0)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.5.2...v4.6.0)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.5.2...v4.6.0

###
[`v4.5.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.5.2)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.5.1...v4.5.2)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.5.1...v4.5.2

###
[`v4.5.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.5.1)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.5.0...v4.5.1)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.5.0...v4.5.1

###
[`v4.5.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.5.0)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.4.5...v4.5.0)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.4.5...v4.5.0

###
[`v4.4.5`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.5)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.4.4...v4.4.5)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.4.4...v4.4.5

###
[`v4.4.4`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.4)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.4.3...v4.4.4)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.4.3...v4.4.4

###
[`v4.4.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.3)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.4.2...v4.4.3)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.4.2...v4.4.3

###
[`v4.4.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.2)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.4.1...v4.4.2)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.4.1...v4.4.2

###
[`v4.4.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.1)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.4.0...v4.4.1)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.4.0...v4.4.1

###
[`v4.4.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.0)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.3.4...v4.4.0)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.3.4...v4.4.0

###
[`v4.3.4`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.4)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.3.3...v4.3.4)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.3.3...v4.3.4

###
[`v4.3.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.3)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.3.2...v4.3.3)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.3.2...v4.3.3

###
[`v4.3.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.2)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.3.1...v4.3.2)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.3.1...v4.3.2

###
[`v4.3.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.1)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.3.0...v4.3.1)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.3.0...v4.3.1

###
[`v4.3.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.2.0...v4.3.0)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.2.0...v4.3.0

###
[`v4.2.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.2.0)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.1.4...v4.2.0)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.1.4...v4.2.0

###
[`v4.1.4`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.4)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.1.3...v4.1.4)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.1.3...v4.1.4

###
[`v4.1.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.3)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.1.2...v4.1.3)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.1.2...v4.1.3

###
[`v4.1.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.2)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.1.1...v4.1.2)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

#### What's Changed

##### Other Changes

- fix [#&#8203;107](https://togithub.com/garronej/tss-react/issues/107)
by [@&#8203;jiby-aurum](https://togithub.com/jiby-aurum) in
[garronej/tss-react#109

#### New Contributors

- [@&#8203;jiby-aurum](https://togithub.com/jiby-aurum) made their first
contribution in
[garronej/tss-react#109

**Full Changelog**:
garronej/tss-react@v4.1.1...v4.1.2

###
[`v4.1.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.1)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.1.0...v4.1.1)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

**Full Changelog**:
garronej/tss-react@v4.1.0...v4.1.1

###
[`v4.1.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.0)

[Compare
Source](https://togithub.com/garronej/tss-react/compare/v4.0.0...v4.1.0)

<!-- Release notes generated using configuration in .github/release.yaml
at refs/heads/main -->

#### What's Changed

##### Other Changes

- v4.1.0-beta by [@&#8203;garronej](https://togithub.com/garronej) in
[garronej/tss-react#106

**Full Changelog**:
garronej/tss-react@v4.0.0...v4.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTI0LjIifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiby-aurum jiby-aurum jiby-aurum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garronej @jiby-aurum