fix(gatsby-source-wordpress): draft previews (#32915)

* debug * fix draft previews * invoke leftover callbacks at the start of preview sourcing * use proper status
gatsbyjs · Aug 26, 2021 · 1810874 · 1810874
1 parent 7c72ab8
commit 1810874
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/packages/gatsby-source-wordpress/src/steps/preview/index.ts b/packages/gatsby-source-wordpress/src/steps/preview/index.ts
@@ -19,6 +19,7 @@ import { formatLogMessage } from "~/utils/format-log-message"
 import { touchValidNodes } from "../source-nodes/update-nodes/fetch-node-updates"
 
 import { Reporter } from "gatsby/reporter"
+import { invokeAndCleanupLeftoverPreviewCallbacks } from "./cleanup"
 
 const inDevelopPreview =
   process.env.NODE_ENV === `development` &&
@@ -367,14 +368,11 @@ export const sourcePreviews = async (helpers: GatsbyHelpers): Promise<void> => {
     dump(webhookBody)
   }
 
-  if (previewForIdIsAlreadyBeingProcessed(webhookBody?.id)) {
-    if (inPreviewDebugMode) {
-      reporter.info(
-        `Preview for id ${webhookBody?.id} is already being sourced.`
-      )
-    }
-    return
-  }
+  // in case there are preview callbacks from our last build
+  await invokeAndCleanupLeftoverPreviewCallbacks({
+    status: `GATSBY_PREVIEW_PROCESS_ERROR`,
+    context: `Starting sourcePreviews`,
+  })
 
   const wpGatsbyPreviewNodeManifestsAreSupported =
     await remoteSchemaSupportsFieldNameOnTypeName({

diff --git a/packages/gatsby-source-wordpress/src/steps/source-nodes/update-nodes/wp-actions/update.js b/packages/gatsby-source-wordpress/src/steps/source-nodes/update-nodes/wp-actions/update.js
@@ -24,6 +24,7 @@ export const fetchAndCreateSingleNode = async ({
   cachedNodeIds,
   token = null,
   isPreview = false,
+  isDraft = false,
   userDatabaseId = null,
 }) => {
   function getNodeQuery() {
@@ -34,7 +35,7 @@ export const fetchAndCreateSingleNode = async ({
     // if it's a preview but it's the initial blank node
     // then use the regular node query as the preview query wont
     // return anything
-    const query = isPreview ? previewQuery : nodeQuery
+    const query = isPreview && !isDraft ? previewQuery : nodeQuery
 
     return query
   }
@@ -81,6 +82,16 @@ export const fetchAndCreateSingleNode = async ({
       )
     )
 
+    reporter.info({
+      singleName,
+      id,
+      actionType,
+      cachedNodeIds,
+      token,
+      isPreview,
+      userDatabaseId,
+    })
+
     return { node: null }
   }