fix(gatsby-plugin-image): Correctly calculate aspect ratio when width…

… and height are both set (#30466)
gatsbyjs · Mar 26, 2021 · 35c90f8 · 35c90f8
1 parent 2f87f89
commit 35c90f8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/gatsby-plugin-image/src/__tests__/image-utils.ts b/packages/gatsby-plugin-image/src/__tests__/image-utils.ts
@@ -311,6 +311,11 @@ describe(`the helper utils`, () => {
     expect(url).toEqual(`https://example.com/afile.jpg/20/15/image.jpg`)
   })
 
+  it(`gets a low-resolution image URL when width and height are set`, () => {
+    const url = getLowResolutionImageURL({ ...args, width: 200, height: 200 })
+    expect(url).toEqual(`https://example.com/afile.jpg/20/20/image.jpg`)
+  })
+
   it(`gets a low-resolution image URL with correct aspect ratio`, () => {
     const url = getLowResolutionImageURL({
       ...fullWidthArgs,

diff --git a/packages/gatsby-plugin-image/src/image-utils.ts b/packages/gatsby-plugin-image/src/image-utils.ts
@@ -168,7 +168,7 @@ export function setDefaultDimensions(
   layout = camelCase(layout) as Layout
 
   if (width && height) {
-    return { ...args, formats, layout }
+    return { ...args, formats, layout, aspectRatio: width / height }
   }
   if (sourceMetadata.width && sourceMetadata.height && !aspectRatio) {
     aspectRatio = sourceMetadata.width / sourceMetadata.height