Fix issue to properly support navigating back by number

gatsbyjs · Jul 9, 2020 · 9a23a55 · 9a23a55
1 parent 2083510
commit 9a23a55
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/e2e-tests/development-runtime/cypress/integration/navigation/linking.js b/e2e-tests/development-runtime/cypress/integration/navigation/linking.js
@@ -33,6 +33,14 @@ describe(`navigation`, () => {
     cy.location(`pathname`).should(`equal`, `/`)
   })
 
+  it(`can navigate using numbers`, () => {
+    cy.getTestElement(`page-two`).click().waitForRouteChange()
+
+    cy.getTestElement(`back-by-number`).click()
+
+    cy.location(`pathname`).should(`equal`, `/`)
+  })
+
   describe(`relative links`, () => {
     it(`can navigate to a subdirectory`, () => {
       cy.getTestElement(`subdir-link`)

diff --git a/e2e-tests/development-runtime/src/pages/page-2.js b/e2e-tests/development-runtime/src/pages/page-2.js
@@ -3,6 +3,7 @@ import { Link } from "gatsby"
 
 import Layout from "../components/layout"
 import SEO from "../components/seo"
+import { navigate } from "gatsby"
 
 const SecondPage = () => (
   <Layout>
@@ -12,6 +13,9 @@ const SecondPage = () => (
     <Link to="/" data-testid="back-button">
       Go back to the homepage
     </Link>
+    <button data-testid="back-by-number" onClick={() => navigate(-1)}>
+      Navigate by number back
+    </button>
   </Layout>
 )
 

diff --git a/packages/gatsby-link/src/index.js b/packages/gatsby-link/src/index.js
@@ -43,6 +43,9 @@ function absolutify(path, current) {
 }
 
 const rewriteLinkPath = (path, relativeTo) => {
+  if (typeof path === `number`) {
+    return path
+  }
   if (!isLocalLink(path)) {
     return path
   }