fix(gatsby): Add back missing partial hydration error handling change (…

…#36676)
gatsbyjs · Sep 23, 2022 · a629551 · a629551
1 parent 17a776d
commit a629551
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/packages/gatsby-cli/src/structured-errors/error-map.ts b/packages/gatsby-cli/src/structured-errors/error-map.ts
@@ -772,7 +772,7 @@ const errors = {
   "80000": {
     text: (context): string =>
       stripIndents(`Building partial HTML failed${
-        context.path ? ` for path "${context.path}"` : ``
+        context?.path ? ` for path "${context.path}"` : ``
       }
 
       This can happen if interactive elements like "useEffect", "useState", "createContext" or event handlers are used in a component without declaring the "client export" directive at the top of the file.

diff --git a/packages/gatsby/src/commands/build-html.ts b/packages/gatsby/src/commands/build-html.ts
@@ -463,23 +463,20 @@ const renderPartialHydrationQueue = async (
   const sessionId = Date.now()
   // const { webpackCompilationHash } = store.getState()
 
-  try {
-    await Promise.all(
-      segments.map(async pageSegment => {
-        await workerPool.single.renderPartialHydrationProd({
-          envVars,
-          paths: pageSegment,
-          sessionId,
-        })
-
-        if (activity && activity.tick) {
-          activity.tick(pageSegment.length)
-        }
+  // Let the error bubble up
+  await Promise.all(
+    segments.map(async pageSegment => {
+      await workerPool.single.renderPartialHydrationProd({
+        envVars,
+        paths: pageSegment,
+        sessionId,
       })
-    )
-  } catch (e) {
-    console.log({ e })
-  }
+
+      if (activity && activity.tick) {
+        activity.tick(pageSegment.length)
+      }
+    })
+  )
 }
 
 class BuildHTMLError extends Error {