Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the slash between the pathPrefix and pathname when navigating #1574

Merged
merged 6 commits into from Jul 20, 2017

Conversation

DaleWebb
Copy link
Contributor

This bug was introduced by (#1550)

@DaleWebb DaleWebb changed the title Remove the slash between the pathPrefix and pathname when navigating Remove the slash between the pathPrefix and pathname when navigating Jul 20, 2017
@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2017

Deploy preview ready!

Built with commit f6bd109

https://deploy-preview-1574--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2017

Deploy preview failed.

Built with commit f6bd109

https://app.netlify.com/sites/gatsbygram/deploys/5970e984cf321c644355a798

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2017

Deploy preview failed.

Built with commit f6bd109

https://app.netlify.com/sites/gatsbyjs/deploys/5970e984cf321c644355a795

@KyleAMathews
Copy link
Contributor

Thanks for the fix!

Could you not do the replace though? We already ensure that the pathPrefix doesn't end with a slash here

@KyleAMathews KyleAMathews merged commit eec27e3 into gatsbyjs:master Jul 20, 2017
@KyleAMathews
Copy link
Contributor

Just pushed a fix myself so can get this out

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit f6bd109

https://app.netlify.com/sites/using-glamor/deploys/5970e985cf321c644355a7aa

@KyleAMathews
Copy link
Contributor

Thanks!

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit f6bd109

https://app.netlify.com/sites/using-remark/deploys/5970e985cf321c644355a7b3

@KyleAMathews
Copy link
Contributor

Fix is out in 1.3.2

@jlengstorf
Copy link
Contributor

Hiya @DaleWebb! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants