WIP: fix: fixes regression with pathPrefix and gatsby-link #1579
Conversation
Note: this is not done! Want to get the tests actually working
|
Deploy preview failed. Built with commit 26c2d78 https://app.netlify.com/sites/using-glamor/deploys/5970dac87960b15b567a2c7a |
|
Deploy preview failed. Built with commit 26c2d78 https://app.netlify.com/sites/using-remark/deploys/5970dac87960b15b567a2c83 |
|
Deploy preview ready! Built with commit 26c2d78 |
|
Deploy preview failed. Built with commit 26c2d78 https://app.netlify.com/sites/gatsbygram/deploys/5970dac77960b15b567a2c68 |
|
Deploy preview failed. Built with commit 26c2d78 https://app.netlify.com/sites/gatsbyjs/deploys/5970dac77960b15b567a2c65 |
|
Looks like the tests are failing due to the glamor issue I'm fixing in #1580 |
|
@KyleAMathews yeah I wasn't so concerned with those, and figured they'd be fixed at some point. Just unsure why I can't set globals like I am for the |
|
Looks like you're setting them right... https://stackoverflow.com/a/40460395 |
|
Merged #1574 and making a release. Would love to get your tests in soon! |
Note: this is not done! Want to get the tests actually working. Unsure why the globals aren't setting, and why I need to use Jest globals :/
Also similar to #1574. We should probably consolidate our efforts