fix(gatsby): Support numbers in navigate function #25611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
blainekasten
added
topic: reach/router and Links
type: feature or enhancement
|
Your pull request can be previewed in Gatsby Cloud: https://build-8fa4b2e7-48a7-475c-96ee-0b6dab9a0b8d.staging-previews.gtsb.io |
pvdz
previously approved these changes
Jul 8, 2020
wardpeet
previously requested changes
Jul 8, 2020
wardpeet
reviewed
Jul 8, 2020
|
@wardpeet I don't think it's intended for gatsby-link. More a programmatic API. I haven't tested gatsby-link and it might take more to make that work |
|
@pvdz I don't think so? This is effectively equivalent to pressing the back or forwards button on the browser. |
pvdz
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Browsers supports navigating with numbers to jump multiple steps forward or backward in the history. Gatsby hasn't supported this yet, but we should to be as aligned with the browsers as we can! This adds that support.
Documentation
Related Issues
Fixes #24739