Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-filesystem): Update createRemoteFileNode args #35422

Merged
merged 6 commits into from Jun 1, 2022

Conversation

Apprentice76
Copy link
Contributor

Description

This is a bugfix for issue #35363 as well as the arguments for 'CreateFileNodeFromBufferArgs'

Documentation

gatsby-source-filesystem docs: https://www.gatsbyjs.com/plugins/gatsby-source-filesystem/#createremotefilenode

Related Issues

Fixes #35363

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 13, 2022
@imjoshin
Copy link
Contributor

Hi @Apprentice76 ! Thanks for the contribution 😄

Looks like there's a few tsc errors in the build:

src/helpers.ts(125,11): error TS2345: Argument of type '{ url: string; cache: GatsbyCache; createNode: <TNode = Record<string, unknown>>(this: void, node: NodeInput & TNode, plugin?: ActionPlugin | undefined, options?: ActionOptions | undefined) => void; createNodeId: (this: void, input: string) => string; parentNodeId: string; store: Store; reporter: Reporter; }' is not assignable to parameter of type 'CreateRemoteFileNodeArgs'.
  Object literal may only specify known properties, and 'store' does not exist in type 'CreateRemoteFileNodeArgs'.

Would you mind fixing these up?

@imjoshin imjoshin added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 15, 2022
@Apprentice76
Copy link
Contributor Author

I'll get to that asap. I updated the function definition, but forgot that there might be packages that might me using the old one. I need to update them as well.

@Apprentice76
Copy link
Contributor Author

Apprentice76 commented Apr 17, 2022

I've updated the PR, the last failing check(s) are a problem somewhere in the cypress scripts in the e2e_test folders and not related to my code. Kindly review and merge it.

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 6, 2022
@LekoArts LekoArts changed the title fix(gatsby-source-filesystem): Bugfix #35363 fix(gatsby-source-filesystem): Update createRemoteFileNode args Jun 1, 2022
@LekoArts LekoArts added the topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) label Jun 1, 2022
@gatsbybot gatsbybot merged commit caaf7a5 into gatsbyjs:master Jun 1, 2022
wickedev added a commit to wickedev/gatsby-source-velog that referenced this pull request Nov 5, 2022
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
…tsbyjs#35422)

* fixes issue gatsbyjs#35363 and CreateFileNodeFromBufferArgs

* modified tests for remote-file-node and file-node-from-buffer

* updated function calls in dependencies

* removed unused typescript imports

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-source-filesystem] Incorrect type definition for createFileNodeForAsset
6 participants