fix(gatsby-source-filesystem): Update createRemoteFileNode args (ga…

…tsbyjs#35422)

* fixes issue gatsbyjs#35363 and CreateFileNodeFromBufferArgs

* modified tests for remote-file-node and file-node-from-buffer

* updated function calls in dependencies

* removed unused typescript imports

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

index.d.ts

@@ -1,4 +1,4 @@
-import { Node, Store, NodePluginArgs } from "gatsby"
+import { Node, GatsbyCache } from "gatsby"
 
 /**
  * @see https://www.gatsbyjs.com/plugins/gatsby-source-filesystem/?=files#createfilepath
@@ -28,9 +28,8 @@ export interface CreateFilePathArgs {
 
 export interface CreateRemoteFileNodeArgs {
   url: string
-  store: Store
-  // TODO: use GatsbyCache type (requires gatsby@2.22.13)
-  cache: NodePluginArgs["cache"]
+  cache?: GatsbyCache
+  getCache?: Function
   createNode: Function
   createNodeId: Function
   parentNodeId?: string
@@ -41,14 +40,12 @@ export interface CreateRemoteFileNodeArgs {
   httpHeaders?: object
   ext?: string
   name?: string
-  reporter: object
 }
 
 export interface CreateFileNodeFromBufferArgs {
   buffer: Buffer
-  store: Store
-  // TODO: use GatsbyCache type (requires gatsby@2.22.13)
-  cache: NodePluginArgs["cache"]
+  cache?: GatsbyCache
+  getCache?: Function
   createNode: Function
   createNodeId: Function
   parentNodeId?: string

src/__tests__/create-file-node-from-buffer.js

@@ -40,15 +40,6 @@ const bufferEq = (b1, b2) => Buffer.compare(b1, b2) === 0
 
 describe(`create-file-node-from-buffer`, () => {
   const defaultArgs = {
-    store: {
-      getState: jest.fn(() => {
-        return {
-          program: {
-            directory: `__whatever__`,
-          },
-        }
-      }),
-    },
     createNode: jest.fn(),
     createNodeId: jest.fn(),
   }

src/__tests__/create-remote-file-node.js

@@ -1,7 +1,5 @@
 import { fetchRemoteFile } from "gatsby-core-utils/fetch-remote-file"
 
-const reporter = {}
-
 const createRemoteFileNode = require(`../create-remote-file-node`)
 
 jest.mock(`gatsby-core-utils/fetch-remote-file`, () => {
@@ -33,11 +31,9 @@ describe(`create-remote-file-node`, () => {
 
   const defaultArgs = {
     url: `https://external.com/dog.jpg`,
-    store: {},
     getCache: () => cache,
     createNode: jest.fn(),
     createNodeId: jest.fn(() => String(uuid++)),
-    reporter,
     ext: `.jpg`,
     name: `dog-thumbnail`,
   }

src/create-remote-file-node.js

@@ -11,11 +11,6 @@ const { createFileNode } = require(`./create-file-node`)
  * @see gatsby/packages/gatsby/utils/cache.js
  */
 
-/**
- * @typedef {Reporter}
- * @see gatsby/packages/gatsby-cli/lib/reporter.js
- */
-
 /**
  * @typedef {Auth}
  * @type {Object}
@@ -33,7 +28,6 @@ const { createFileNode } = require(`./create-file-node`)
  * @param  {Function} options.createNode
  * @param  {Function} options.getCache
  * @param  {Auth} [options.auth]
- * @param  {Reporter} [options.reporter]
  */
 
 /******************