Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the onClick override logic #1489

Merged
merged 5 commits into from Jul 19, 2017
Merged

Fix the onClick override logic #1489

merged 5 commits into from Jul 19, 2017

Commits on Jul 13, 2017

  1. Fix the onClick override logic 

    Solution is almost a direct copy/paste from react-router's Link
component (as suggested):
https://github.com/ReactTraining/react-router/blob/676e8ac14da780e9fbd32
7576971fe549f3d0b8c/packages/react-router-dom/modules/Link.js#L40-L43

Now, cmd/ctrl-clicking opens links in a new tab, as expected! Also,
target="_blank" now works.
    @jacobdeichert
    jacobdeichert committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    980d098 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2017

  1. Adjust if statement

    @jacobdeichert
    jacobdeichert committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    0592493 View commit details
    Browse the repository at this point in the history

  2. Simplify further

    @jacobdeichert
    jacobdeichert committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    cd931c9 View commit details
    Browse the repository at this point in the history

  3. Prevent onClick logic sooner

    @jacobdeichert
    jacobdeichert committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    1fb1fb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. Merge branch 'master' into topic/fix-gatsby-link-click-override

    @KyleAMathews
    KyleAMathews committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    45dd1a3 View commit details
    Browse the repository at this point in the history