New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prism plugin bugfix alt #1491
Merged
KyleAMathews
merged 5 commits into
gatsbyjs:master
from
bvaughn:prism-plugin-bugfix-alt
Jul 13, 2017
Merged
Prism plugin bugfix alt #1491
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
582706a
Replace class=language-* with data-language=* to avoid potential Pris…
bvaughn c28fe1e
Remark Prism plugin now accepts useDataAttribute option
bvaughn 4e09661
Alternate, custom-class-prefix approach to fixing Prism+ReactLive bug
bvaughn 13e48f9
Added README note about new plugin option
bvaughn d30d1c6
Provided more context for the remark prism docs comment
bvaughn File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
packages/gatsby-remark-prismjs/src/__tests__/__snapshots__/index.js.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`remark prism plugin generates a <pre> tag with a custom class prefix if configured 1`] = ` | ||
Object { | ||
"children": Array [ | ||
Object { | ||
"lang": "js", | ||
"position": Position { | ||
"end": Object { | ||
"column": 4, | ||
"line": 3, | ||
"offset": 17, | ||
}, | ||
"indent": Array [ | ||
1, | ||
1, | ||
], | ||
"start": Object { | ||
"column": 1, | ||
"line": 1, | ||
"offset": 0, | ||
}, | ||
}, | ||
"type": "html", | ||
"value": "<div class=\\"gatsby-highlight\\"> | ||
<pre class=\\"custom-js\\"><code><span class=\\"token comment\\" spellcheck=\\"true\\">// Fake</span> | ||
</code></pre> | ||
</div>", | ||
}, | ||
], | ||
"position": Object { | ||
"end": Object { | ||
"column": 4, | ||
"line": 3, | ||
"offset": 17, | ||
}, | ||
"start": Object { | ||
"column": 1, | ||
"line": 1, | ||
"offset": 0, | ||
}, | ||
}, | ||
"type": "root", | ||
} | ||
`; | ||
|
||
exports[`remark prism plugin generates a <pre> tag with class="language-*" prefix by default 1`] = ` | ||
Object { | ||
"children": Array [ | ||
Object { | ||
"lang": "js", | ||
"position": Position { | ||
"end": Object { | ||
"column": 4, | ||
"line": 3, | ||
"offset": 17, | ||
}, | ||
"indent": Array [ | ||
1, | ||
1, | ||
], | ||
"start": Object { | ||
"column": 1, | ||
"line": 1, | ||
"offset": 0, | ||
}, | ||
}, | ||
"type": "html", | ||
"value": "<div class=\\"gatsby-highlight\\"> | ||
<pre class=\\"language-js\\"><code><span class=\\"token comment\\" spellcheck=\\"true\\">// Fake</span> | ||
</code></pre> | ||
</div>", | ||
}, | ||
], | ||
"position": Object { | ||
"end": Object { | ||
"column": 4, | ||
"line": 3, | ||
"offset": 17, | ||
}, | ||
"start": Object { | ||
"column": 1, | ||
"line": 1, | ||
"offset": 0, | ||
}, | ||
}, | ||
"type": "root", | ||
} | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
const remark = require(`remark`) | ||
const plugin = require(`../index`) | ||
|
||
describe(`remark prism plugin`, () => { | ||
it(`generates a <pre> tag with class="language-*" prefix by default`, () => { | ||
const code = '```js\n// Fake\n```' | ||
const markdownAST = remark.parse(code) | ||
plugin({ markdownAST }) | ||
expect(markdownAST).toMatchSnapshot() | ||
}) | ||
|
||
it(`generates a <pre> tag with a custom class prefix if configured`, () => { | ||
const code = '```js\n// Fake\n```' | ||
const markdownAST = remark.parse(code) | ||
plugin({ markdownAST }, { classPrefix: 'custom-' }) | ||
expect(markdownAST).toMatchSnapshot() | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps rewrite this sentence slightly so makes clear this option is only needed when loading prismjs into the browser and this is not very common.