feat(gatsby): Make __experimentalThemes part of plugin APIs #15144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dupe fragments in the e2es |
|
|
|
It looks like https://github.com/gatsbyjs/gatsby/pull/15179/files means we can remove the theme logic from the query compiler, which also fixes the duplicate fragments issue here |
wardpeet
reviewed
Jul 1, 2019
| @@ -257,17 +257,7 @@ module.exports = async (program, directory, suppliedStage) => { | |||
| rules.media(), | |||
| rules.miscAssets(), | |||
| ] | |||
| if (store.getState().themes.themes) { | |||
This change makes it so that what used to be called `__experimentalThemes` is now part of the `plugins` APIs. This means that any plugin can take advantage of the Theme APIs like Component Shadowing. * This change contains no functional changes to how themes work today. * `__experimentalThemes` and `plugins` style themes can not be used at the same time. If `__experimentalThemes` is defined, it takes precedence so as to not break existing sites. The plan here is to not break existing sites while enabling the stable version of themes to be used. We (I most likely) should go back and remove the `__experimentalThemes` handling after a suitable deprecation period. **I'd like to see this released under a tag so we can test it on a wider range of sites before merging** \# TODO - [ ] Add deprecation message for __experimentalThemes (should we do this in this PR or another?) - [ ] Should we expand the webpack handling of themes in `packages/gatsby/src/utils/webpack.config.js` to work on all plugins? I think I remember another PR
Because of gatsbyjs#14111, we can remove the custom theme processing.
ChristopherBiscardi
force-pushed
the
themes-are-plugins
branch
from
159d5c6
to
79da69b
Compare
|
#15179 fixes the duplicated fragment issue |
|
Failing tests are result of duplicated plugin entries (fix in #15307 ) |
This reverts commit 81d55c3.
sidharthachatterjee
changed the title
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that what used to be called
__experimentalThemesis now part of the
pluginsAPIs. This means that any plugin can takeadvantage of the Theme APIs like Component Shadowing.
__experimentalThemes, we can change this logic to be more plugin-specific.__experimentalThemesandpluginsstyle themes can not be used at thesame time. If
__experimentalThemesis defined, it takes precedenceso as to not break existing sites.
The plan here is to not break existing sites while enabling the stable
version of themes to be used. We (I most likely) should go back and remove
the
__experimentalThemeshandling after a suitable deprecation period.I'd like to see this released under a tag so we can test it on a wider range of sites before merging
TODO
packages/gatsby/src/utils/webpack.config.jsto work on all plugins? What's the status of feat(gatsby): enable babel-loader for all dependencies #14111 in relation to this?