Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-theme-notes): Render correct breadcrumb path based on basePath #16556

Conversation

jakewies
Copy link
Contributor

Description

In scenarios where the basePath option is not provided, it defaults to "/". When this happens, the breadcrumbs render as such:

~ / / example-dir

This is due to a regex replacement that causes the base breadcrumb text to be an empty string:

basePath.replace(/^\//, ``)

The initial breadcrumb divider should only render if there is a custom basePath (or more importantly, if the basePath has a text length). This results in proper breadcrumb text:

~ / example-dir

Related Issues

Closes #15493

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you so much @jakewies and congratulations on your first contribution to Gatsby 💜

@sidharthachatterjee sidharthachatterjee changed the title fix: render correct breadcrumb path based on basePath fix(gatsby-theme-notes): Render correct breadcrumb path based on basePath Aug 13, 2019
@sidharthachatterjee sidharthachatterjee merged commit 17a41ae into gatsbyjs:master Aug 13, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 13, 2019

Holy buckets, @jakewies — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@jakewies
Copy link
Contributor Author

Thanks @sidharthachatterjee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-theme-notes] showing improper breadcrumbs when basePath is set to default value.
3 participants