Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-remark-images): support markdownCaptions in mdx + fix for remark #21188

Merged
merged 7 commits into from
Apr 22, 2020
Merged

feat(gatsby-remark-images): support markdownCaptions in mdx + fix for remark #21188

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c67b6d
pass compiler to gatsby-remark-* plugins in the mdx plugin
mathieudutour Feb 4, 2020
0d2d0bf
Merge branch 'master' into f/pass-compiler-to-remark-plugins
mathieudutour Apr 16, 2020
8ae40fd
make getImageCaption async
mathieudutour Apr 16, 2020
b593428
use async mdx compiler
mathieudutour Apr 16, 2020
d37fb5e
fix for using compiler
mathieudutour Apr 16, 2020
17085db
don't mutate the node multiple times
mathieudutour Apr 19, 2020
c5a8bcb
convert markdown ast to html ast
mathieudutour Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/gatsby-plugin-mdx/utils/gen-mdx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ export const _frontmatter = ${JSON.stringify(data)}`
reporter,
cache,
pathPrefix,
compiler: {
parseString: compiler.parse.bind(compiler),
generateHTML: ast => mdx.sync(ast, options),
mathieudutour marked this conversation as resolved.
Show resolved Hide resolved
},
...helpers,
}
)
Expand Down