Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump node min version to 10.13.0 #22400

Merged
merged 14 commits into from Mar 20, 2020
Merged

chore: bump node min version to 10.13.0 #22400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
de85ccf
Drop node 8 support
freiksenet Mar 19, 2020
9474a95
Add blog post
freiksenet Mar 19, 2020
27b2ab7
Test Node 10.13
freiksenet Mar 19, 2020
e7c8051
Test on 10.13 exactly
freiksenet Mar 19, 2020
61b5856
Remove extra 8.0 test
freiksenet Mar 19, 2020
723c1cd
Address review comments
freiksenet Mar 19, 2020
28dc767
Mention got
freiksenet Mar 19, 2020
3bba64b
Restore image
freiksenet Mar 19, 2020
ee9a612
Add yarnrc
freiksenet Mar 19, 2020
f79532e
Remove personal info
freiksenet Mar 19, 2020
81ac9d4
Keep ignore engines
freiksenet Mar 19, 2020
b497586
use yarn 1.21
pieh Mar 19, 2020
fdda356
Update docs/blog/2020-03-20-dropping-support-for-node-8/index.md
freiksenet Mar 20, 2020
b19060b
Apply suggestions from code review
freiksenet Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 5 additions & 15 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ executors:
parameters:
image:
type: string
default: "10"
default: "10.13"
docker:
- image: circleci/node:<< parameters.image >>

Expand Down Expand Up @@ -69,7 +69,7 @@ aliases:
- /blog.+/
requires:
- lint
- unit_tests_node8
- unit_tests_node10

e2e_tests_production_runtime_alias: &e2e_tests_production_runtime_alias
<<: *e2e-executor
Expand Down Expand Up @@ -238,12 +238,6 @@ jobs:
- run: yarn typecheck
- run: yarn check-repo-fields

unit_tests_node8:
executor:
name: node
image: "8"
<<: *test_template

unit_tests_node10:
executor: node
<<: *test_template
Expand Down Expand Up @@ -633,24 +627,20 @@ workflows:
- lint:
requires:
- bootstrap
- unit_tests_node8:
<<: *ignore_docs
requires:
- bootstrap
- unit_tests_node10:
<<: *ignore_docs
requires:
- lint
- unit_tests_node8
- bootstrap
- unit_tests_node12:
<<: *ignore_docs
requires:
- lint
- unit_tests_node8
- bootstrap
- unit_tests_www:
requires:
- lint
- unit_tests_node8
- bootstrap
- integration_tests_long_term_caching:
<<: *e2e-test-workflow
- integration_tests_gatsby_pipeline:
Expand Down