Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serve command in cli #237

Merged
merged 2 commits into from Apr 9, 2016
Merged

Add serve command in cli #237

merged 2 commits into from Apr 9, 2016

Conversation

alehlopeh
Copy link
Contributor

I needed to preview the output of gatsby build before deploying, so I added a serve command to the cli. Pretty basic.

@KyleAMathews
Copy link
Contributor

Interesting... I've just been using http-server so hadn't seen a need but I
can see the value of having something built-in. What are other's thoughts?

I think the name "serve" is a bit ambiguous as it would get confused
sometimes with the "develop" command.
On Thu, Apr 7, 2016 at 7:19 PM alehlopeh notifications@github.com wrote:

I needed to preview the output of gatsby build before deploying, so I

added a serve command to the cli. Pretty basic.

You can view, comment on, or merge this pull request online at:

#237
Commit Summary

  • Add serve command in cli
  • pass tests

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#237

@KyleAMathews KyleAMathews merged commit 5e4b71f into gatsbyjs:master Apr 9, 2016
KyleAMathews added a commit that referenced this pull request Apr 9, 2016
@KyleAMathews
Copy link
Contributor

I merged this new command and renamed it to serve-build. Thanks!

@alehlopeh
Copy link
Contributor Author

Cool. The name I chose was pretty weak, I'll admit, but I'm glad you found it useful enough to merge.
Great work on gatsby btw. I use it a lot.

@KyleAMathews
Copy link
Contributor

Definitely a useful idea and great code. Glad Gatsby has been helpful!
On Tue, Apr 12, 2016 at 5:41 AM alehlopeh notifications@github.com wrote:

Cool. The name I chose was pretty weak, I'll admit, but I'm glad you found
it useful enough to merge.
Great work on gatsby btw. I use it a lot.


You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#237 (comment)

@jlengstorf
Copy link
Contributor

Hiya @alehlopeh! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants