chore(gatsby-source-graphql): upgrade to graphql-tools v6

[yaacovCR]

Description

Upgrade dependency graphql-tools to v6

Major change is that in v6, graphql-js objects are considered immutable, hopefully leading to greater interoperability.

Pending release of v6.

Documentation

https://www.graphql-tools.com/

[blainekasten]

Marking this as blocked until v6 is released, also assigning to @vladar who leads most of our graphql effort.

[vladar]

@yaacovCR Congrats with the v6 release of graphql-tools! 🎉

The PR looks good to me but I need to try it locally before merging (and also check out the changelog of graphql-tools). I will get back to you when I have a chance to do this. And thanks a lot for your help with migration to v6! 💜

[yaacovCR]

Happy to help,

I also noticed you seem to have to work around a few issues in GraphQL compose when you are rebuilding a schema...

I wonder if using some of our utilities functions would help you out with that, as you can see from above, mapSchema let's you start from any initial schema and do the composition on built graphql schema objects.

Not really sure why you are rebuilding, what has changed and what hasn't and whether this would help you but just figured I would flag it.

We built some helper functions that can add types and modify object fields using the above approach, but there are additional possibilities that might help you as well.

[yaacovCR]

Upgrade to latest graphql-tools version, v6.0.9, also switched gatsby-recipes to use scoped packages for smaller bundle size.

Fix of interest: ardatan/graphql-tools#1572

[yaacovCR]

Note that I did not change the metadata recipe to use the newer functional directive approach. We are hoping to still provide backwards compatibility with the current approach.

Also, populating metadata is still an unresolved issue overall, with the guidance from graphql-js to use the extensions field for graphql objects, but no built-in approach to populating it. I think that the eventual solution (possibly built on something like graphql-tools's functional directive approach?) should really be in graphql-js, and it seems counterproductive to iterate through multiple interim solutions.

[vladar]

Sorry for the delay with this. We are having a company event this week, so I will revisit it the next week.

Also can you please post a separate PR for gatsby-recipes changes? The reason is that we're using conventional commits and ideally, single PR should affect a single package.

[yaacovCR]

Will do

[yaacovCR]

@johno

[yaacovCR]

Hmmm, looks like Gatsby recipes changes made it, but not this one...

[yaacovCR]

@vladar @johno let me know if I messed up something....

[vladar]

Can you rebase or merge master? I am going to test it locally first thing tomorrow and then we can merge if everything is fine!

[vladar]

Sorry for the delay, just got to testing. It fails for me with an error:

TypeError: executor is not a function

Here:

gatsby/packages/gatsby-source-graphql/src/gatsby-node.js

Line 71 in 5ad9582

introspectionSchema = await introspectSchema(link)

I belive it's because introspectSchema expects executor vs link now:

export async function introspectSchema(executor: AsyncExecutor, context?: Record<string, any>): Promise<GraphQLSchema> 

[vladar]

Actually the fix was a quick one (just pushed). Trying to resolve conflicts and make the tests pass, which is harder :)

[vladar]

Ok, works as expected after the quick fix. Let's merge this 🚢

Will publish it as a new minor

[vladar]

Published in gatsby-source-graphql@2.6.0