Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add calcPrefixDefault() function #24790

Closed
wants to merge 1 commit into from

Conversation

planetcohen
Copy link

Description

Instantiating a Link component in a Jest/ReactTestingLibrary unit test was generating a reference error:

    ReferenceError: __BASE_PATH__ is not defined

This PR uses the code existed in a previous version of this function to ensure that this error doesn't happen.

Related Issues

Fixes Issue #24789

@planetcohen planetcohen requested a review from a team as a code owner June 4, 2020 21:35
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 4, 2020
Copy link
Contributor

@kruton kruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me.

@freiksenet freiksenet added status: inkteam assigned and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 5, 2020
@sidharthachatterjee
Copy link
Contributor

Looks like this was fixed in #25608

Thank you nonetheless for opening this PR. Closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants