chore: upgrade core-js to version 3 #25158

wardpeet · 2020-06-20T15:53:29Z

Description

Upgrade babel-preset & gatsby to core-js 3. Core-js 2 has been deprecated for a while but we never had a good story to upgrade it. Now with the polyfill work we're doing we can.

I've added a core-js resolver to make sure packages that are still compiled with core-js@2 are still working. It also makes our bundles smaller when core-js@2 is used inside the site itself.

Documentation

Nope

Related Issues

Fixes #15601
Fixes #23254
Addresses #24859

wardpeet · 2020-06-20T15:53:50Z

packages/gatsby-cli/src/index.ts

@@ -46,7 +45,7 @@ if (semver.prerelease(version)) {
  report.warn(
    report.stripIndent(`
    You are currently using a prerelease version of Node (${version}), which is not supported.
-    You can use this for testing, but we do not recommend it in production. 
+    You can use this for testing, but we do not recommend it in production.


This is prettier

wardpeet · 2020-06-20T15:54:50Z

packages/gatsby-cli/package.json

@@ -11,7 +11,6 @@
  },
  "dependencies": {
    "@babel/code-frame": "^7.10.1",
-    "@babel/runtime": "^7.10.2",


this was unused

wardpeet · 2020-06-20T15:54:58Z

packages/gatsby-cli/src/index.ts

@@ -1,6 +1,5 @@
 #!/usr/bin/env node

-import "@babel/polyfill"


we don't need this anymore (node 10.13 is pretty good)

polarathene · 2020-06-22T06:55:44Z

This will still trigger the warning afaik due to a long dependency chain to fbjs which has received no updates for 2 years to npm. There was a recent PR to address the core-js v3 warning there too, however it's only been merged without pushing an update out.

warning gatsby > gatsby-cli > gatsby-recipes > graphql-tools > @graphql-tools/relay-operation-optimizer > relay-compiler > fbjs > core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

freiksenet · 2020-06-22T07:41:19Z

@polarathene Great catch! I've created an issue for recipes team to handle this. #25184

wardpeet · 2020-06-23T06:39:18Z

I need to publish a minor for babel-presets cause it's "breaking"

packages/gatsby/src/utils/webpack/corejs-resolver.ts

blainekasten · 2020-06-23T13:58:19Z

packages/gatsby/src/utils/webpack.config.js

@@ -614,7 +615,6 @@ module.exports = async (
      `@reach/router/lib/history`,
      `@reach/router`,
      `common-tags`,
-      /^core-js\//,


why don't we want this external anymore? or does the resolver do this somehow?

I saw this break sometimes with gatsby-dev, never with a regular yarn install, so more or less just a precaution.

So should we bring it back then before we ship? My understanding of this array (based on the comment above) is that we force these libs into a common bundle to not bloat page bundles. Doesn't removing this line put core-js in each bundle?

Before we weren't merging core-js into SSR bundles to reduce size. I'll try to add it back and see what tests say.

blainekasten

General approach is looking great! It feels like this could very well break for people with edge cases. I'm wondering if we should wait for v3 on this?

wardpeet · 2020-06-23T14:06:48Z

General approach is looking great! It feels like this could very well break for people with edge cases. I'm wondering if we should wait for v3 on this?

I tested lots of cases haven't find any issues. It can only fail when core-js is used in the root or packages are not configured correctly. This will also become less of an issue when we merge #25159 & #25162.

This improves performance so much and fixes lots of issues with people having libraries that depend on core-js@3. I'm willing to take that shot. We can always revert if I didn't do my homework

blainekasten · 2020-06-23T14:33:09Z

@wardpeet that sounds good. I'm happy to see this merged if you're ready to own the reverting process if it does raise bad bugs. But I trust you did your homework and the code looks good. Getting core-js 3 will be a big win!

wardpeet · 2020-06-23T16:02:25Z

i'll fix the interop and merge it tomorrow

packages/gatsby/src/utils/webpack/__tests__/corejs-resolver.ts

blainekasten · 2020-07-01T14:16:47Z

@wardpeet do we need to upgrade gatsby-plugin-mdx?

gatsby/packages/gatsby-plugin-mdx/package.json

Line 30 in d63c0a3

"core-js": "2",

blainekasten

This is phenomenal. Tested locally and things are working great!

robbienohra · 2020-07-01T15:54:08Z

This merge makes me very happy 🥳 🎉

wadkar · 2020-07-01T20:31:55Z

Thanks a lot @wardpeet !! This is great 🥳 🎊

This reverts commit a5396ef.

* chore: upgrade to core-js@3 * add tests to core-js resolver * update babel-preset tests

gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 20, 2020

wardpeet commented Jun 20, 2020

View reviewed changes

wardpeet marked this pull request as ready for review June 20, 2020 16:36

wardpeet requested a review from a team as a code owner June 20, 2020 16:36

freiksenet previously approved these changes Jun 22, 2020

View reviewed changes

freiksenet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 22, 2020

wardpeet removed the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 22, 2020

wardpeet dismissed freiksenet’s stale review via aeae1ee June 22, 2020 21:07

wardpeet force-pushed the feat/core-js-resolver branch from 8524100 to aeae1ee Compare June 22, 2020 21:07

pieh added breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: webpack/babel Webpack or babel labels Jun 23, 2020

blainekasten reviewed Jun 23, 2020

View reviewed changes

packages/gatsby/src/utils/webpack/corejs-resolver.ts Show resolved Hide resolved

blainekasten reviewed Jun 23, 2020

View reviewed changes

packages/gatsby/src/utils/webpack/corejs-resolver.ts Show resolved Hide resolved

blainekasten reviewed Jun 23, 2020

View reviewed changes

blainekasten mentioned this pull request Jun 23, 2020

Updated Core JS to v3 #25233

Closed

ehrencrona reviewed Jun 23, 2020

View reviewed changes

packages/gatsby/src/utils/webpack/__tests__/corejs-resolver.ts Outdated Show resolved Hide resolved

LekoArts mentioned this pull request Jun 26, 2020

Warnings on installing Gatsby: 4 x Deprecated issues #24859

Closed

wardpeet force-pushed the feat/core-js-resolver branch 3 times, most recently from 66c2f54 to f37df54 Compare June 29, 2020 21:45

wardpeet force-pushed the feat/core-js-resolver branch 3 times, most recently from c69e5b6 to 5b2a50a Compare July 1, 2020 10:42

wardpeet added 3 commits July 1, 2020 14:55

chore: upgrade to core-js@3

e565012

add tests to core-js resolver

b8f7f12

update babel-preset tests

d63c0a3

wardpeet force-pushed the feat/core-js-resolver branch from 5b2a50a to d63c0a3 Compare July 1, 2020 13:03

blainekasten approved these changes Jul 1, 2020

View reviewed changes

blainekasten merged commit a5396ef into master Jul 1, 2020

delete-merged-branch bot deleted the feat/core-js-resolver branch July 1, 2020 14:44

wardpeet added a commit that referenced this pull request Jul 2, 2020

Revert "chore: upgrade core-js to version 3 (#25158)"

c9e77ba

This reverts commit a5396ef.

wardpeet mentioned this pull request Jul 2, 2020

Revert "chore: upgrade core-js to version 3" #25474

Merged

danabrit pushed a commit that referenced this pull request Jul 2, 2020

chore: upgrade core-js to version 3 (#25158)

ba9b945

* chore: upgrade to core-js@3 * add tests to core-js resolver * update babel-preset tests

wardpeet restored the feat/core-js-resolver branch July 3, 2020 22:00

jonathanstanley mentioned this pull request Jul 5, 2020

Upgrade core-js package to version 3 #15601

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade core-js to version 3 #25158

chore: upgrade core-js to version 3 #25158

wardpeet commented Jun 20, 2020 •

edited by ehrencrona

wardpeet Jun 20, 2020

wardpeet Jun 20, 2020

wardpeet Jun 20, 2020 •

edited

polarathene commented Jun 22, 2020

freiksenet commented Jun 22, 2020 •

edited

wardpeet commented Jun 23, 2020

blainekasten Jun 23, 2020

wardpeet Jun 23, 2020

blainekasten Jun 23, 2020

wardpeet Jun 29, 2020

blainekasten left a comment

wardpeet commented Jun 23, 2020

blainekasten commented Jun 23, 2020

wardpeet commented Jun 23, 2020

blainekasten commented Jul 1, 2020

blainekasten left a comment

robbienohra commented Jul 1, 2020

wadkar commented Jul 1, 2020

chore: upgrade core-js to version 3 #25158

chore: upgrade core-js to version 3 #25158

Conversation

wardpeet commented Jun 20, 2020 • edited by ehrencrona

Description

Documentation

Related Issues

wardpeet Jun 20, 2020

Choose a reason for hiding this comment

wardpeet Jun 20, 2020

Choose a reason for hiding this comment

wardpeet Jun 20, 2020 • edited

Choose a reason for hiding this comment

polarathene commented Jun 22, 2020

freiksenet commented Jun 22, 2020 • edited

wardpeet commented Jun 23, 2020

blainekasten Jun 23, 2020

Choose a reason for hiding this comment

wardpeet Jun 23, 2020

Choose a reason for hiding this comment

blainekasten Jun 23, 2020

Choose a reason for hiding this comment

wardpeet Jun 29, 2020

Choose a reason for hiding this comment

blainekasten left a comment

Choose a reason for hiding this comment

wardpeet commented Jun 23, 2020

blainekasten commented Jun 23, 2020

wardpeet commented Jun 23, 2020

blainekasten commented Jul 1, 2020

blainekasten left a comment

Choose a reason for hiding this comment

robbienohra commented Jul 1, 2020

wadkar commented Jul 1, 2020

wardpeet commented Jun 20, 2020 •

edited by ehrencrona

wardpeet Jun 20, 2020 •

edited

freiksenet commented Jun 22, 2020 •

edited