Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(gatsby-plugin-mdx): prevent babel parse step at sourcing time #25437

Merged
merged 3 commits into from
Jul 8, 2020
Merged

perf(gatsby-plugin-mdx): prevent babel parse step at sourcing time #25437

merged 3 commits into from
Jul 8, 2020

Commits on Jul 7, 2020

  1. perf(gatsby-plugin-mdx): prevent babel parse step at sourcing time 

    The mdx plugin was doing its default parsing step for every time it got called. At sourcing time it's only called to retrieve the import bindings and for this we can be much faster by manually processing the import statements. So that's what this does.

A very simple flat no-image mdx benchmark cuts down sourcing time in half for this change.
    @pvdz
    pvdz committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    9edcaf3 View commit details
    Browse the repository at this point in the history

  2. Support multiple import statements together

    @pvdz
    pvdz committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    6969461 View commit details
    Browse the repository at this point in the history

  3. Drop comments

    @pvdz
    pvdz committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    9e4e124 View commit details
    Browse the repository at this point in the history