Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-manifest): re-use domain connection #26946

Merged
merged 3 commits into from
Sep 27, 2020
Merged

fix(gatsby-plugin-manifest): re-use domain connection #26946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a1b8a2
fix(gatsby-plugin-manifest): re-use domain connection
wardpeet Sep 7, 2020
972527c
fix tests
wardpeet Sep 25, 2020
8f9ff76
Merge remote-tracking branch 'upstream/master' into fix/manifest-doub…
Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/gatsby-plugin-manifest/src/__tests__/__snapshots__/gatsby-ssr.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Array [
exports[`gatsby-plugin-manifest CORS Generation Does not add crossOrigin when 'crossOrigin' is blank 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -42,6 +43,7 @@ Array [
type="image/png"
/>,
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -101,6 +103,7 @@ Array [
type="image/png"
/>,
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -160,6 +163,7 @@ Array [
type="image/png"
/>,
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -219,6 +223,7 @@ Array [
type="image/png"
/>,
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -268,6 +273,7 @@ Array [
exports[`gatsby-plugin-manifest Cache Busting doesn't add cache busting in manual mode 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -297,6 +303,7 @@ Array [
type="image/png"
/>,
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -306,6 +313,7 @@ Array [
exports[`gatsby-plugin-manifest Favicon Does not add a link favicon if "include_favicon" option is set to false 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -315,6 +323,7 @@ Array [
exports[`gatsby-plugin-manifest Favicon Does not add a link favicon if in manual mode 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -324,6 +333,7 @@ Array [
exports[`gatsby-plugin-manifest Legacy Icons Does create legacy links if "legacy" not specified in automatic mode 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -373,6 +383,7 @@ Array [
exports[`gatsby-plugin-manifest Legacy Icons Does create legacy links if "legacy" not specified in hybrid mode. 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -392,6 +403,7 @@ Array [
exports[`gatsby-plugin-manifest Legacy Icons Does create legacy links if "legacy" not specified in manual mode. 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -411,6 +423,7 @@ Array [
exports[`gatsby-plugin-manifest Legacy Icons Does not create legacy links If "legacy" options is false and in automatic 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -420,6 +433,7 @@ Array [
exports[`gatsby-plugin-manifest Legacy Icons Does not create legacy links If "legacy" options is false and in hybrid mode 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -429,6 +443,7 @@ Array [
exports[`gatsby-plugin-manifest Legacy Icons Does not create legacy links If "legacy" options is false and in manual mode 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -442,6 +457,7 @@ Array [
exports[`gatsby-plugin-manifest Manifest Link Generation Add a "theme color" meta tag if "theme_color_in_head" is set to true 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -465,6 +481,7 @@ Array [
type="image/png"
/>,
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -518,6 +535,7 @@ Array [
exports[`gatsby-plugin-manifest Manifest Link Generation Adds a "theme color" meta tag to head if "theme_color_in_head" is not provided 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -531,6 +549,7 @@ Array [
exports[`gatsby-plugin-manifest Manifest Link Generation Adds correct (default) i18n "manifest" link to head 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -580,6 +599,7 @@ Array [
exports[`gatsby-plugin-manifest Manifest Link Generation Adds correct (es) i18n "manifest" link to head 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest_es.webmanifest"
rel="manifest"
/>,
Expand Down Expand Up @@ -629,6 +649,7 @@ Array [
exports[`gatsby-plugin-manifest Manifest Link Generation Does not add a "theme color" meta tag if "theme_color_in_head" is set to false 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand All @@ -638,6 +659,7 @@ Array [
exports[`gatsby-plugin-manifest Manifest Link Generation Does not add a "theme_color" meta tag to head if "theme_color" option is not provided. 1`] = `
Array [
<link
crossOrigin="anonymous"
href="/manifest.webmanifest"
rel="manifest"
/>,
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-manifest/src/gatsby-ssr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports.onRenderBody = (
include_favicon: insertFaviconLinkTag,
theme_color_in_head: insertMetaTag,
theme_color,
crossOrigin,
crossOrigin = `anonymous`,
}
) => {
// We use this to build a final array to pass as the argument to setHeadComponents at the end of onRenderBody.
Expand Down