Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove inlined yarn #28551

Closed
wants to merge 1 commit into from

Conversation

sidharthachatterjee
Copy link
Contributor

I'm forgetting why exactly we did this but it appears unnecessary and it's certainly a better idea to use a locally available yarn so that

  • we don't completely opt out of updates that include bug fixes (I'm currently hitting one for retext not being found which is fixed when I upgrade)
  • we don't inline all of yarn in our repo 馃槄

@pieh Do you remember why we did this and if it is necessary anymore? Maybe it was CI? I feel like there ought to be a better solution here nonetheless.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 9, 2020
@sidharthachatterjee sidharthachatterjee removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 9, 2020
@pieh
Copy link
Contributor

pieh commented Dec 9, 2020

It was part of #22400

Because docker image for some of things running in CI use like yarn 1.10 or so which fails hard :)

This also made sure that everyone using repo is using same yarn and yarn.lock doesn't change randomly depending on used yarn version.

If we are hitting bugs in yarn - let's upgrade this "checked in" version instead

@wardpeet wardpeet closed this Dec 9, 2020
@LekoArts LekoArts deleted the chore/remove-inlined-yarn branch April 23, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants