Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-manifest): Fix or Joi assertion #29242

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

LekoArts
Copy link
Contributor

Description

Fixes #29112 (comment)

According to the docs with or already one of the two is required:

Defines a relationship between keys where one of the peers is required (and more than one is allowed)

So having required() on both of them leads to the error that it's still required.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 28, 2021
@LekoArts LekoArts added topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 28, 2021
wardpeet
wardpeet previously approved these changes Jan 28, 2021
@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 28, 2021
@LekoArts LekoArts merged commit 844ac84 into master Jan 28, 2021
@LekoArts LekoArts deleted the manifest-fix-or branch January 28, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid plugin options "related_applications" gatsby-plugin-manifest
2 participants