chore: update eslint to fix linting issues #29988
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,22 @@ | ||
| module.exports = { | ||
| parser: `@babel/eslint-parser`, | ||
| extends: [ | ||
|
Comment on lines
-11
to
-12
There was a problem hiding this comment. these are now inside prettier |
||
| `google`, | ||
| `eslint:recommended`, | ||
| `plugin:flowtype/recommended`, | ||
| `plugin:react/recommended`, | ||
| `prettier`, | ||
| ], | ||
| plugins: [`flowtype`, `prettier`, `react`, `filenames`, `@babel`], | ||
|
There was a problem hiding this comment. Added @babel to augment the this rules |
||
| parserOptions: { | ||
| ecmaVersion: 2016, | ||
| sourceType: `module`, | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| babelOptions: { | ||
| configFile: `./.babelrc.js`, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
|
|
@@ -39,43 +38,63 @@ module.exports = { | |
| __ASSET_PREFIX__: true, | ||
| }, | ||
| rules: { | ||
| "@babel/no-unused-expressions": [ | ||
| `error`, | ||
| { | ||
| allowTaggedTemplates: true, | ||
| }, | ||
| ], | ||
| "no-unused-expressions": `off`, | ||
| "@babel/no-invalid-this": `error`, | ||
| "no-invalid-this": `off`, | ||
| "arrow-body-style": [ | ||
| `error`, | ||
| `as-needed`, | ||
| { requireReturnForObjectLiteral: true }, | ||
| ], | ||
| "new-cap": `off`, | ||
| "no-unused-vars": [ | ||
| `warn`, | ||
| { | ||
| varsIgnorePattern: `^_`, | ||
| argsIgnorePattern: `^_`, | ||
| ignoreRestSiblings: true, | ||
| }, | ||
| ], | ||
| "consistent-return": [`error`], | ||
| "filenames/match-regex": [`error`, `^[a-z-\\d\\.]+$`, true], | ||
| "no-console": `off`, | ||
| "no-inner-declarations": `off`, | ||
| "prettier/prettier": `error`, | ||
| quotes: [`error`, `backtick`], | ||
| "react/display-name": `off`, | ||
| "react/jsx-key": `warn`, | ||
| "react/no-unescaped-entities": `off`, | ||
| "react/prop-types": `off`, | ||
| "require-jsdoc": `off`, | ||
| "valid-jsdoc": `off`, | ||
| "prefer-promise-reject-errors": `warn`, | ||
| "no-prototype-builtins": `warn`, | ||
| "guard-for-in": `warn`, | ||
|
Comment on lines
+76
to
+78
There was a problem hiding this comment. These are new rules and moved them to warnings because there were too many. |
||
| "spaced-comment": [ | ||
| `error`, | ||
| `always`, | ||
| { markers: [`/`], exceptions: [`*`, `+`] }, | ||
| ], | ||
| camelcase: [ | ||
| `error`, | ||
| { | ||
| properties: `never`, | ||
| ignoreDestructuring: true, | ||
| allow: [`^unstable_`], | ||
| }, | ||
| ], | ||
|
Comment on lines
+84
to
+91
There was a problem hiding this comment. I have no idea why this wasn't necessary before 🤷 |
||
| }, | ||
| overrides: [ | ||
| { | ||
| files: [ | ||
| `packages/**/gatsby-browser.js`, | ||
| `packages/gatsby/cache-dir/**/*`, | ||
| ], | ||
| env: { | ||
| browser: true, | ||
|
|
@@ -86,115 +105,115 @@ module.exports = { | |
| }, | ||
| }, | ||
| { | ||
| files: [`**/cypress/integration/**/*`, `**/cypress/support/**/*`], | ||
| globals: { | ||
| cy: false, | ||
| Cypress: false, | ||
| }, | ||
| }, | ||
| { | ||
| files: [`*.ts`, `*.tsx`], | ||
| parser: `@typescript-eslint/parser`, | ||
| plugins: [`@typescript-eslint/eslint-plugin`], | ||
| extends: [`plugin:@typescript-eslint/recommended`], | ||
| rules: { | ||
| // We should absolutely avoid using ts-ignore, but it's not always possible. | ||
| // particular when a dependencies types are incorrect. | ||
| "@typescript-eslint/ban-ts-comment": [ | ||
| `warn`, | ||
| { "ts-ignore": `allow-with-description` }, | ||
| ], | ||
| // This rule is great. It helps us not throw on types for areas that are | ||
| // easily inferrable. However we have a desire to have all function inputs | ||
| // and outputs declaratively typed. So this let's us ignore the parameters | ||
| // inferrable lint. | ||
| "@typescript-eslint/no-inferrable-types": [ | ||
| `error`, | ||
| { ignoreParameters: true }, | ||
| ], | ||
| "@typescript-eslint/ban-types": [ | ||
| `error`, | ||
| { | ||
| extendDefaults: true, | ||
| types: { | ||
| "{}": { | ||
| fixWith: `Record<string, unknown>`, | ||
| }, | ||
| object: { | ||
| fixWith: `Record<string, unknown>`, | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| camelcase: `off`, | ||
| // TODO: These rules allow a lot of stuff and don't really enforce. If we want to apply our styleguide, we'd need to fix a lot of stuff | ||
| "@typescript-eslint/naming-convention": [ | ||
| `error`, | ||
| { | ||
| selector: `default`, | ||
| format: [`camelCase`], | ||
| }, | ||
| { | ||
| selector: `variable`, | ||
| format: [`camelCase`, `UPPER_CASE`, `PascalCase`], | ||
| leadingUnderscore: `allowSingleOrDouble`, | ||
| trailingUnderscore: `allowSingleOrDouble`, | ||
| }, | ||
| { | ||
| selector: `function`, | ||
| format: [`camelCase`, `PascalCase`], | ||
| leadingUnderscore: `allow`, | ||
| }, | ||
| { | ||
| selector: `parameter`, | ||
| format: [`camelCase`, `PascalCase`, `snake_case`], | ||
| leadingUnderscore: `allowSingleOrDouble`, | ||
| }, | ||
| { | ||
| selector: `enumMember`, | ||
| format: [`camelCase`, `UPPER_CASE`, `PascalCase`], | ||
| }, | ||
| { | ||
| selector: `typeLike`, | ||
| format: [`PascalCase`], | ||
| }, | ||
| { | ||
| selector: `typeAlias`, | ||
| format: [`camelCase`, `PascalCase`], | ||
| }, | ||
| { | ||
| selector: `property`, | ||
| format: [`PascalCase`, `UPPER_CASE`, `camelCase`, `snake_case`], | ||
| leadingUnderscore: `allowSingleOrDouble`, | ||
| }, | ||
| { | ||
| selector: `objectLiteralProperty`, | ||
| format: [`PascalCase`, `UPPER_CASE`, `camelCase`, `snake_case`], | ||
| leadingUnderscore: `allowSingleOrDouble`, | ||
| trailingUnderscore: `allowSingleOrDouble`, | ||
| }, | ||
| { | ||
| selector: `enum`, | ||
| format: [`PascalCase`, `UPPER_CASE`], | ||
| }, | ||
| { | ||
| selector: `method`, | ||
| format: [`PascalCase`, `camelCase`], | ||
| leadingUnderscore: `allowSingleOrDouble`, | ||
| }, | ||
| { | ||
| selector: `interface`, | ||
| format: [`PascalCase`], | ||
| prefix: [`I`], | ||
| }, | ||
| ], | ||
| // This rule tries to prevent using `require()`. However in node code, | ||
| // there are times where this makes sense. And it specifically is causing | ||
| // problems in our tests where we often want this functionality for module | ||
| // mocking. At this point it's easier to have it off and just encourage | ||
| // using top-level imports via code reviews. | ||
| "@typescript-eslint/no-var-requires": `off`, | ||
| "@typescript-eslint/no-extra-semi": `off`, | ||
| // This rule ensures that typescript types do not have semicolons | ||
| // at the end of their lines, since our prettier setup is to have no semicolons | ||
| // e.g., | ||
|
|
@@ -203,50 +222,50 @@ module.exports = { | |
| // + baz: string | ||
| // } | ||
| "@typescript-eslint/member-delimiter-style": [ | ||
| `error`, | ||
| { | ||
| multiline: { | ||
| delimiter: `none`, | ||
| }, | ||
| }, | ||
| ], | ||
| "@typescript-eslint/no-empty-function": `off`, | ||
| // This ensures that we always type the return type of functions | ||
| // a high level focus of our TS setup is typing fn inputs and outputs. | ||
| "@typescript-eslint/explicit-function-return-type": `error`, | ||
| // This forces us to use interfaces over types aliases for object definitions. | ||
| // Type is still useful for opaque types | ||
| // e.g., | ||
| // type UUID = string | ||
| "@typescript-eslint/consistent-type-definitions": [ | ||
| `error`, | ||
| `interface`, | ||
| ], | ||
| "@typescript-eslint/no-use-before-define": [ | ||
| `error`, | ||
| { functions: false }, | ||
| ], | ||
| // Allows us to write unions like `type Foo = "baz" | "bar"` | ||
| // otherwise eslint will want to switch the strings to backticks, | ||
| // which then crashes the ts compiler | ||
| quotes: `off`, | ||
| "@typescript-eslint/quotes": [ | ||
| 2, | ||
| `backtick`, | ||
| { | ||
| avoidEscape: true, | ||
| }, | ||
| ], | ||
| // bump to @typescript-eslint/parser started showing Flow related errors in ts(x) files | ||
| // so disabling them in .ts(x) files | ||
| "flowtype/no-types-missing-file-annotation": `off`, | ||
| "@typescript-eslint/array-type": [`error`, { default: `generic` }], | ||
| }, | ||
| }, | ||
| ], | ||
| settings: { | ||
| react: { | ||
| version: `16.9.0`, | ||
| }, | ||
| }, | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| import React, { Component } from "react" | ||
|
|
||
| class ClassComponent extends Component { | ||
| state = { | ||
| custom: true, | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks linting as babel will return an empty ast. Packages should be build with
babel src --out-dir . --ignore \"**/__tests__\"