Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): fix signature for latest experimental version of react-dom #31750

Merged
merged 2 commits into from Jun 4, 2021
Merged

fix(gatsby): fix signature for latest experimental version of react-dom #31750

merged 2 commits into from Jun 4, 2021

Conversation

cometkim
Copy link
Contributor

@cometkim cometkim commented Jun 3, 2021

Description

In latest version of react/react-dom@experimental, there is no unstable_ prefix for createRoot

Related Issues

See facebook/react#21488

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 3, 2021
wardpeet
wardpeet reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's move everything to the new syntax and remove unstable_createRoot. Also can you update the message that they have to use at least that version

@cometkim
Copy link
Contributor Author

cometkim commented Jun 3, 2021

Yep found it. It's https://www.npmjs.com/package/react/v/0.0.0-experimental-2bf4805e4 published 22 days ago.

@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 4, 2021
wardpeet
wardpeet approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wardpeet wardpeet merged commit 087cdd5 into gatsbyjs:master Jun 4, 2021
@cometkim cometkim deleted the react-experimental branch June 6, 2021 10:47
@gatsbybot gatsbybot mentioned this pull request Jun 8, 2021
Merged
vladar pushed a commit that referenced this pull request Jun 8, 2021
@cometkim @vladar
fix(gatsby): fix signature for latest experimental version of react-d…
1ac89e1 
…om (#31750)

(cherry picked from commit 087cdd5)
@vladar vladar added this to To cherry-pick in Release candidate via automation Jun 8, 2021
@wardpeet wardpeet removed this from To cherry-pick in Release candidate Jun 8, 2021
@vladar vladar added this to To cherry-pick in Release candidate via automation Jun 8, 2021
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Jun 8, 2021
vladar pushed a commit that referenced this pull request Jun 8, 2021
@cometkim
fix(gatsby): fix signature for latest experimental version of react-d…
2a4ea62 
…om (#31750) (#31829)

(cherry picked from commit 087cdd5)

Co-authored-by: Hyeseong Kim <hey@hyeseong.kim>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Jun 8, 2021
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@ViCo0TeCH
fix(gatsby): fix signature for latest experimental version of react-d…
d2cd20f 
…om (gatsbyjs#31750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cometkim @wardpeet @LekoArts