Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Gatsby Head API #35980

Merged
merged 69 commits into from
Jul 14, 2022
Merged

feat(gatsby): Gatsby Head API #35980

merged 69 commits into from
Jul 14, 2022

Commits on Jun 8, 2022

  1. initial work

    @marvinjude
    marvinjude committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    194a690 View commit details
    Browse the repository at this point in the history

  2. add latest

    @marvinjude
    marvinjude committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5beb48b View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. implement in page renderer

    @marvinjude
    marvinjude committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    bb56387 View commit details
    Browse the repository at this point in the history

  2. progress

    @marvinjude
    marvinjude committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    40549d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. make static query work when used in export

    @marvinjude
    marvinjude committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2597e9f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. cleanup

    @marvinjude
    marvinjude committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    361ad85 View commit details
    Browse the repository at this point in the history

  2. don't warn for 'head' export

    @marvinjude
    marvinjude committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    69b39cc View commit details
    Browse the repository at this point in the history

  3. cleanup & append head nodes to head at once

    @marvinjude
    marvinjude committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    36d296e View commit details
    Browse the repository at this point in the history

  4. add warnings

    @marvinjude
    marvinjude committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5357b5c View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. update warning

    @marvinjude
    marvinjude committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    6b7bb4f View commit details
    Browse the repository at this point in the history

  2. remove use less function

    @marvinjude
    marvinjude committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    e03a316 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. add TS Types

    @marvinjude
    marvinjude committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    923a08e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into poc/metadata-management

    @marvinjude
    marvinjude committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    eb33292 View commit details
    Browse the repository at this point in the history

  3. test(gatsby): Metadata management e2e tests (#35979) 

    * Test pages setup

* More test page scaffolding

* Tests for development-runtime

* DRY raw strings with shared data pattern

* Production runtime tests

* Remove override test, we don't need it
    @tyhopp
    tyhopp committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f48beff View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. fix test

    @marvinjude
    marvinjude committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    f5d5288 View commit details
    Browse the repository at this point in the history

  2. fix hydration issue

    @marvinjude
    marvinjude committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0751f0d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. use react to render into head instead of parsing and appending result… 

    …ing child nodes
    @marvinjude
    marvinjude committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    3d7e8af View commit details
    Browse the repository at this point in the history

  2. fix test

    @marvinjude
    marvinjude committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    cbc4324 View commit details
    Browse the repository at this point in the history

  3. don't invalid head element for HTML

    @marvinjude
    marvinjude committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    70dd9a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. remove warning test in prod

    @marvinjude
    marvinjude committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    a8c2a9b View commit details
    Browse the repository at this point in the history

  2. do react 18 checks for create root/ render

    @marvinjude
    marvinjude committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    e3f2571 View commit details
    Browse the repository at this point in the history

  3. remove all props page test

    @marvinjude
    marvinjude committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    940f02e View commit details
    Browse the repository at this point in the history

  4. wrap head element with server location and props provider

    @marvinjude
    marvinjude committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c7e80d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Merge branch 'master' into feat/metadata-management

    @marvinjude
    marvinjude committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c69941a View commit details
    Browse the repository at this point in the history

  2. Fix borked yarn.lock

    @tyhopp
    tyhopp committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    167fb4e View commit details
    Browse the repository at this point in the history

  3. Update dev-loader test snapshot

    @tyhopp
    tyhopp committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c2acf0a View commit details
    Browse the repository at this point in the history

  4. Update packages/gatsby/cache-dir/dev-loader.js 

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
    @marvinjude @pieh
    marvinjude and pieh committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    5efa140 View commit details
    Browse the repository at this point in the history

  5. Update packages/gatsby/cache-dir/loader.js 

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
    @marvinjude @pieh
    marvinjude and pieh committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    544e1d5 View commit details
    Browse the repository at this point in the history

  6. Update packages/gatsby/cache-dir/page-renderer.js 

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
    @marvinjude @pieh
    marvinjude and pieh committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    8dd4fa8 View commit details
    Browse the repository at this point in the history

  7. Update packages/gatsby/cache-dir/static-entry.js 

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
    @marvinjude @pieh
    marvinjude and pieh committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    42d72d6 View commit details
    Browse the repository at this point in the history

  8. create shared function for render and hydrate

    @marvinjude
    marvinjude committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4bab3eb View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Fix lint error

    @tyhopp
    tyhopp committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    56da964 View commit details
    Browse the repository at this point in the history

  2. Remove unused functions

    @tyhopp
    tyhopp committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f5969a6 View commit details
    Browse the repository at this point in the history

  3. Ensure params are passed with props in page renderer

    @tyhopp
    tyhopp committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    7169fa0 View commit details
    Browse the repository at this point in the history

  4. Fix eslint test assertion

    @tyhopp
    tyhopp committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    6370a5f View commit details
    Browse the repository at this point in the history

  5. remove unnecessary spread operator

    @marvinjude
    marvinjude committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2fe95f2 View commit details
    Browse the repository at this point in the history

  6. remove no-op setAttribute addition

    @marvinjude
    marvinjude committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f218a32 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. feat(head-function-export): Correct props (#36008)

    @LekoArts
    LekoArts committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    a2506d6 View commit details
    Browse the repository at this point in the history

  2. test(head-function-export): Ensure head elements in SSR'ed HTML (#36006) 

    * test(head-function-export): Ensure head elements in SSR'ed HTML

* Add integration_tests_head_function_export to CI workflows
    @tyhopp
    tyhopp committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    ee3c07a View commit details
    Browse the repository at this point in the history

  3. test(head-function-export): More e2e tests (#36014) 

    * test(head-function-export): DSG, SSR pages

* Invalid elements

* Explicit add and removal of DOM nodes

* FS Route API test

* Refactor invalid elements test
    @tyhopp
    tyhopp committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    664133d View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. create SSR and browser handler for head export

    @marvinjude
    marvinjude committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    8fac6b6 View commit details
    Browse the repository at this point in the history

  2. fix import and condition

    @marvinjude
    marvinjude committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4a50f2f View commit details
    Browse the repository at this point in the history

  3. add head handler for DEV SSR

    @marvinjude
    marvinjude committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    e1ca969 View commit details
    Browse the repository at this point in the history

  4. test(head-function-export): Test in DEV_SSR mode (#36007) 

    test(dev-ssr): Ensure head function export works in DEV_SSR mode
    @tyhopp
    tyhopp committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1f80113 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. feat(head-function-export): Hot update for Head export (#36060) 

    * changes so far

* comment loading indicator

* remove 'Head' from page template bundle

* add test for HMR

* fix Head rendering for develop

* fix Head HMR in develop

* revert removal of loading indicator

* fix eslint rule to exclude uppercased Head

* unify webpack loader that removes exports

* split Head and template only in develop

* fix loader tests

* fix flaky test?

* add test for head hot reloading

* avoid doing multiple createRoot

* remove unused code

* change head to Head

* use the correct head export

* change head to Head

* babel and eslint fixes and tests

* remove console logs

* remove previous metadata during navigation

* missing eslint rule tests

* Revert "remove previous metadata during navigation"

This reverts commit b15ada2.

* remove incorrect deps array

* re-export @babel/preset-react

* fix reexport error

* fix all-props test

* remove deps array

* Fix hot-reloading/page-component test

* Fix hot-reloading/head-export test

* Update packages/gatsby/src/utils/webpack.config.js

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>

* fix static query

* source maps

* don't pass in nulls

* fix static image issue

* Potential fix

* cleanup previous fix

* update snapshot

* fix flaky hot-reloading/head-export test

Co-authored-by: pieh <misiek.piechowiak@gmail.com>
Co-authored-by: tyhopp <hopp.ty.c@gmail.com>
    @marvinjude @pieh @tyhopp
    3 people committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    b9c565e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/metadata-management

    @marvinjude
    marvinjude committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    a223b6d View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. fix(head-function-export): Make tsx pages work (#36114)

    @tyhopp
    tyhopp committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    9635085 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/metadata-management

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4bfb485 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @tyhopp
    tyhopp committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    fc53d38 View commit details
    Browse the repository at this point in the history

  4. cleaup tags on navigation

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c01ffc2 View commit details
    Browse the repository at this point in the history

  5. remove test images

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a1bd8ec View commit details
    Browse the repository at this point in the history

  6. Update e2e-tests/development-runtime/cypress/integration/head-functio… 

    …n-export/correct-props.js

Co-authored-by: Lennart <lekoarts@gmail.com>
    @marvinjude @LekoArts
    marvinjude and LekoArts committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ebd9ca4 View commit details
    Browse the repository at this point in the history

  7. Update packages/gatsby/cache-dir/fast-refresh-overlay/components/runt… 

    …ime-errors.js

Co-authored-by: Lennart <lekoarts@gmail.com>
    @marvinjude @LekoArts
    marvinjude and LekoArts committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    def1743 View commit details
    Browse the repository at this point in the history

  8. fixes from dot com testing

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    0836cdf View commit details
    Browse the repository at this point in the history

  9. review update

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    e55541a View commit details
    Browse the repository at this point in the history

  10. review update

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    2117f0a View commit details
    Browse the repository at this point in the history

  11. remove extra formatting

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    0732354 View commit details
    Browse the repository at this point in the history

  12. review update

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ba1e5e8 View commit details
    Browse the repository at this point in the history

  13. review update

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    0cb42a2 View commit details
    Browse the repository at this point in the history

  14. review updates

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    fa454d0 View commit details
    Browse the repository at this point in the history

  15. remove all export query param

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    9a6790d View commit details
    Browse the repository at this point in the history

  16. fix duplicate tags added because we call onHeadRendered twice

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8ccb9c5 View commit details
    Browse the repository at this point in the history

  17. .waitForRouteChange() everywhere

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8486a93 View commit details
    Browse the repository at this point in the history

  18. add additional e2e tests

    @marvinjude
    marvinjude committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4451b04 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Fix dsg, ssr tests

    @tyhopp
    tyhopp committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    2a668ec View commit details
    Browse the repository at this point in the history

  2. add Head type shorthand

    @LekoArts
    LekoArts committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    b649b2d View commit details
    Browse the repository at this point in the history

  3. Fix React 18 hydration error due to stringified all props

    @tyhopp
    tyhopp committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    6f79729 View commit details
    Browse the repository at this point in the history

  4. update type name

    @LekoArts
    LekoArts committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    4722284 View commit details
    Browse the repository at this point in the history

  5. warn once for same message

    @marvinjude
    marvinjude committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    9df3cc2 View commit details
    Browse the repository at this point in the history