Plugin Library build fixes #3906

gillkyle · 2018-02-08T00:55:44Z

This is a continuation of #3456

A new dependency release and a few files (www/gatsby_node.js and yarn.lock) caused issues with the Travis CI build. I forked the most recent branch from jastack and resolved those issues and removed the package-lock.json file.

There are still some things from the original thread (#3456 <-- that PR # is conveniently easy to type) that need to be resolved like some UI issues - mobile support, etc. - that I thought could be included later or summed up here and then worked on. I could also make a project board with all the remaining notes that need to be addressed if that would be helpful.

If there are other changes I should add before this moves forward I'd be happy to keep working on them!

Fixes #3164.

* page path defaults to '/' * Add test

* Check for graymatter excerpt Checks to see if there is a gray-matter excerpt before returning a pruned character count * Fix test Remove a variable that wasn't being used * Create page to describe excerpts * Update using-remark example * Remove package-lock.json * Remove console.log statements * Update copy Updates copy to be a bit more descriptive * Update header for example page * Begin stubbing out extend-node.js tests Created a basic framework for creating a markdown node via the onCreateNode function. This should be expanded to factor in the changes that occur in the setFieldsOnGraphQLNodeType function. * Add query test Adds a test that uses graphql to query a node with its excerpt * Regroup tests Regroups tests so that graphql queries and node tests are in their own groups * Fix linting errors Fixes linting errors that were causing issues on travisCI * Format

* Upgrade style-loader to 0.19.0 to fix webpack-contrib/style-loader#182 * Update to last version

- gatsby-link@1.6.34 - gatsby-source-faker@1.0.0 - gatsby-transformer-remark@1.7.27 - gatsby@1.9.151

* Updated links for Glamor and Styled Components * Update index.md

* Don't generate pages for test files * Use parsedPath.base instead of path

- gatsby-plugin-netlify@1.0.13 - gatsby-transformer-remark@1.7.28 - gatsby@1.9.152

This reverts commit 834dcb8. A number of people were reporting that this broke the default starter in node 8 e.g. https://twitter.com/Lehanism/status/951397594953076737

- gatsby@1.9.153

* Fix Links Redirection * Fix Glamor Link Redirection

* Cleanup Glamor / Styled Component mini-tutorials * Tweaks

reusabilty => reusability

* Update Deploy Gatsby page - Gitlab Pages Have made a few edits, mainly to include the Path Prefix plugin, which is needed when using Gitlab pages without a custom domain. This has basically been shamelessly copied from the Github pages example... Also did a bit of formatting. * fix typo

* correct key behavior * remove trailing slash logic * remove adding new variable

- gatsby-plugin-create-client-paths@1.0.2 - gatsby-react-router-scroll@1.0.8 - gatsby@1.9.154

Add Strata starter to the list.

- gatsby-source-wordpress@2.0.43

* update styled-jsx dep in gatsby-plugin-styled-jsx * move styled-jsx to peerDependencies in gatsby-plugin-styled-jsx

gillkyle · 2018-02-28T17:12:57Z

@calcsam I added two missing dependencies but looks like building the static html is still failing. Looks like not all the data some of the packages needs is making it's way down after querying, trying to make that a little safer.

This error: Error: Could not find function loadNodeContent for plugin gatsby-source-npm-pa ckage-search is one I don't see locally so I'm not sure what issue is causing it. Looking into both...

KyleAMathews · 2018-02-28T18:22:53Z

packages/gatsby-source-npm-package-search/src/gatsby-node.js

+    hitsPerPage: 1000,
+  })
+
+  // TODO: Currently the gatsby-transformer-remark plugin


This needs fixed

@KyleAMathews I pulled this out and found the problem packages, in terms of fixing is something like a little regular expression that replaces the badges and images with empty strings in the readme's content (so the markdown can still function) good?

KyleAMathews · 2018-02-28T18:23:37Z

packages/gatsby-source-npm-package-search/src/gatsby-node.js

+      internal: {
+        type: `NPMPackageReadme`,
+        mediaType: `text/markdown`,
+        content: hit.readme,


To fix the loadNodeContent error — check that hit.readme is always defined as a string — so check if it's not defined and if it isn't, set it as any empty string.

…nditional rendering of specific metadata not pulled by every package

KyleAMathews · 2018-03-02T00:43:46Z

It's alive!!! https://deploy-preview-3906--gatsbyjs.netlify.com/packages/ :-D

gillkyle · 2018-03-02T00:47:50Z

A couple of those little badges look a little wonky after I took out the snippet that was skipping the readmes with images:

But they seem to work?..

KyleAMathews · 2018-03-02T01:01:40Z

Yeah, we should be skipping any READMEs.

The badges seemed affected by our default underline CSS for links — we could override that for these pages.

calcsam · 2018-03-02T01:32:37Z

soooo beautifulllll

…

On Thu, Mar 1, 2018 at 5:01 PM, Kyle Mathews ***@***.***> wrote: Yeah, we should be skipping any READMEs. The badges seemed affected by our default underline CSS for links — we could override that for these pages. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3906 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEL3W8xiMCSmU4Pi8Dj8sHdiMi1pKBVIks5taJn4gaJpZM4R9oo8> .

shannonbux · 2018-03-02T23:00:29Z

wow @gillkyle it looks awesomeeeeeeeeee. The search runs so fast I almost thought it wasn't working lol! So speedy! Very excited!!! On Thu, Mar 1, 2018 at 6:32 PM, Sam Bhagwat <notifications@github.com> wrote:

…

soooo beautifulllll On Thu, Mar 1, 2018 at 5:01 PM, Kyle Mathews ***@***.***> wrote: > Yeah, we should be skipping any READMEs. > > The badges seemed affected by our default underline CSS for links — we > could override that for these pages. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3906 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ AEL3W8xiMCSmU4Pi8Dj8sHdiMi1pKBVIks5taJn4gaJpZM4R9oo8> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3906 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ae9o2uy9h8YJalSPtjNxruZQ4NP9Y4PFks5taKE8gaJpZM4R9oo8> .

calcsam · 2018-03-03T01:39:12Z

It doesn't seem to load all the examples? Eg https://deploy-preview-3906--gatsbyjs.netlify.com/packages?=source doesn't show 51 results, it shows only 20 or so. Should we be adding pagination?

gillkyle · 2018-03-04T00:17:45Z

@calcsam yeah I had noticed that. I switched out the widget we were using for one that allows infinite scroll via a load more button (so it's basically paginated for every 20 results now). However, changing that added some issues to how the selected item in the search list works that I'm trying to sort out, fixing one thing just adds another issue 😅

calcsam · 2018-03-05T03:29:19Z

Haha well almost there! The pagination looks nice. Let us know when the selection issue is fixed and then we can merge in!

…

On Sat, Mar 3, 2018 at 4:17 PM, gillkyle ***@***.***> wrote: @calcsam <https://github.com/calcsam> yeah I had noticed that. I switched out the widget we were using for one that allows infinite scroll via a load more button (so it's basically paginated for every 20 results now). However, changing that added some issues to how the selected item in the search list works that I'm trying to sort out, fixing one thing just adds another issue 😅 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3906 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEL3W3hYJEhM2p8zxA76rUzQf1ZunNTsks5tazKsgaJpZM4R9oo8> .

…ed, and added PropTypes and not found data so undefined errors don't break package readme template components

gillkyle · 2018-03-06T01:02:30Z

@calcsam @KyleAMathews I fixed the highlighting issue, I refactored how the pages for each package were created too because a few pages (I think it was 4) were getting skipped over and instead added in some default not found data.

I think it's about there! 🤞

calcsam · 2018-03-06T18:12:38Z

Cool! Merging.

danoc and others added 30 commits January 24, 2018 13:45

Support URLs that end in SemVer ranges (#3305)

40df85e

Fixes #3164.

page path defaults to '/' (#3325)

396ae6e

* page path defaults to '/' * Add test

handles integer with valida date format correctly (#3461)

771f241

Upgrade style-loader to fix CSS modules issue (#3283)

9c1935a

* Upgrade style-loader to 0.19.0 to fix webpack-contrib/style-loader#182 * Update to last version

format/bootstrap

95e5af7

Publish

03c19fb

- gatsby-link@1.6.34 - gatsby-source-faker@1.0.0 - gatsby-transformer-remark@1.7.27 - gatsby@1.9.151

Updated links for Glamor and Styled Components (#3462)

de876dd

* Updated links for Glamor and Styled Components * Update index.md

Update tutorial.js

c881201

Add link to the using-remark website

f1eb95c

Don't create pages for test files (#3464)

65e851f

* Don't generate pages for test files * Use parsedPath.base instead of path

Add gatsby-source-behance to plugins list (#3465)

74b1ebe

activated mergeLinkHeaders (#3463)

60c0533

Add cache-control examples to caching docs page (#3468)

5ad3b38

Publish

4c1bbeb

- gatsby-plugin-netlify@1.0.13 - gatsby-transformer-remark@1.7.28 - gatsby@1.9.152

Revert "Upgrade style-loader to fix CSS modules issue (#3283)"

4ef16d0

This reverts commit 834dcb8. A number of people were reporting that this broke the default starter in node 8 e.g. https://twitter.com/Lehanism/status/951397594953076737

Publish

ec1b7ac

- gatsby@1.9.153

Fix Links Redirection (#3471)

80775eb

* Fix Links Redirection * Fix Glamor Link Redirection

Fix typo (#3470)

74be3d8

Update tutorial-links.yml

b007e5a

Cleanup Glamor / Styled Component mini-tutorials (#3474)

d4cc9f1

* Cleanup Glamor / Styled Component mini-tutorials * Tweaks

Fix typo in building with components section (#3476)

f9846a2

reusabilty => reusability

Fix typo (#3477)

84c31f6

correct key behavior (#3483)

3fbba4e

* correct key behavior * remove trailing slash logic * remove adding new variable

Publish

bbc764c

- gatsby-plugin-create-client-paths@1.0.2 - gatsby-react-router-scroll@1.0.8 - gatsby@1.9.154

Add Strata starter (#3488)

5d3a508

Add Strata starter to the list.

Use _.isPlainObject to prevent false Array positives (#3490)

2f4cf0e

Publish

3c1fa01

- gatsby-source-wordpress@2.0.43

update styled-jsx dep in gatsby-plugin-styled-jsx (#3493)

2fba7b4

* update styled-jsx dep in gatsby-plugin-styled-jsx * move styled-jsx to peerDependencies in gatsby-plugin-styled-jsx

KyleAMathews suggested changes Feb 28, 2018

View reviewed changes

shannonbux added this to Done in UX Project Feb 28, 2018

keeping undefined objects from being accessed with default values, co…

c5e7bf6

…nditional rendering of specific metadata not pulled by every package

shannonbux moved this from Done to In progress in UX Project Feb 28, 2018

shannonbux added the UX Design label Feb 28, 2018

jlengstorf mentioned this pull request Mar 1, 2018

[RFC] Create Gatsby desktop app with focus on helping non-programmers start and develop and publish Gatsby sites #4201

Closed

fix loadNodeContent error, remove old comments

3e6c48c

gillkyle added 3 commits March 3, 2018 17:07

added infinite scroll for plugins

159126c

Merge remote-tracking branch 'upstream/master'

86ecd9a

Merge branch 'master' into plugins-fixes

473ca9b

gillkyle added 4 commits March 5, 2018 15:59

highlighting results list with pagination fix

4695344

Merge remote-tracking branch 'upstream/master'

41b8362

Merge branch 'master' into plugins-fixes

dc290f8

refactor create page logic to make sure all packages have pages creat…

6a0af0f

…ed, and added PropTypes and not found data so undefined errors don't break package readme template components

calcsam merged commit 652e677 into gatsbyjs:master Mar 6, 2018

UX Project automation moved this from In progress to Done Mar 6, 2018

ghost removed the review label Mar 6, 2018

tejzpr mentioned this pull request Feb 7, 2024

[Snyk] Fix for 17 vulnerabilities tejzpr/gatsby#63

Open

X-oss-byte mentioned this pull request Apr 15, 2024

[Snyk] Upgrade sharp from 0.26.3 to 0.33.3 X-oss-byte/gatsby-1#658

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plugin Library build fixes #3906

Plugin Library build fixes #3906

gillkyle commented Feb 8, 2018

gillkyle commented Feb 28, 2018 •

edited

KyleAMathews Feb 28, 2018

gillkyle Mar 2, 2018

KyleAMathews Feb 28, 2018

KyleAMathews commented Mar 2, 2018

gillkyle commented Mar 2, 2018

KyleAMathews commented Mar 2, 2018

calcsam commented Mar 2, 2018 via email

shannonbux commented Mar 2, 2018 via email

calcsam commented Mar 3, 2018 •

edited

gillkyle commented Mar 4, 2018

calcsam commented Mar 5, 2018 via email

gillkyle commented Mar 6, 2018

calcsam commented Mar 6, 2018

Plugin Library build fixes #3906

Plugin Library build fixes #3906

Conversation

gillkyle commented Feb 8, 2018

gillkyle commented Feb 28, 2018 • edited

KyleAMathews Feb 28, 2018

Choose a reason for hiding this comment

gillkyle Mar 2, 2018

Choose a reason for hiding this comment

KyleAMathews Feb 28, 2018

Choose a reason for hiding this comment

KyleAMathews commented Mar 2, 2018

gillkyle commented Mar 2, 2018

KyleAMathews commented Mar 2, 2018

calcsam commented Mar 2, 2018 via email

shannonbux commented Mar 2, 2018 via email

calcsam commented Mar 3, 2018 • edited

gillkyle commented Mar 4, 2018

calcsam commented Mar 5, 2018 via email

gillkyle commented Mar 6, 2018

calcsam commented Mar 6, 2018

gillkyle commented Feb 28, 2018 •

edited

calcsam commented Mar 3, 2018 •

edited