Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gatsby v1-to-v2 guide to include add'l guidance on removal of layouts #6700

Merged
merged 1 commit into from Jul 24, 2018

Conversation

bw
Copy link
Contributor

@bw bw commented Jul 24, 2018

This is an update to the v1-to-v2 guide in the docs, adding more clarity on the design shift from layouts-wrap-pages to pages-wrap-components. It includes a link to the ongoing discussion in #6127.

I also flipped, within that section of the guide, the order of #4 and #5. It seems to me that it's more likely that someone is using props in layouts than using queries. This order roughly prioritizes the tasks for upgrading components by order of likelihood.

@KyleAMathews
Copy link
Contributor

Deploy preview for using-remark failed.

Built with commit c93c841

https://app.netlify.com/sites/using-remark/deploys/5b5771cb792f895e0e21f8de

@KyleAMathews
Copy link
Contributor

Deploy preview for image-processing failed.

Built with commit c93c841

https://app.netlify.com/sites/image-processing/deploys/5b5771c9792f895e0e21f8d6

@KyleAMathews
Copy link
Contributor

Deploy preview for using-postcss-sass failed.

Built with commit c93c841

https://app.netlify.com/sites/using-postcss-sass/deploys/5b5771c9792f895e0e21f8d2

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit c93c841

https://deploy-preview-6700--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit c93c841

https://deploy-preview-6700--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Deploy preview for gatsbyjs failed.

Built with commit c93c841

https://app.netlify.com/sites/gatsbyjs/deploys/5b5771c8792f895e0e21f8ca

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nicely written and I'm sure people will appreciate the clarifications here while upgrading.

@KyleAMathews KyleAMathews merged commit 193dbb1 into gatsbyjs:master Jul 24, 2018
@gatsbot
Copy link

gatsbot bot commented Jul 24, 2018

Holy buckets, @bw — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants