Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a group, not manual formatting of results #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michamos
Copy link

Uses the ::group workflow command to group the results instead of printing ASCII delimiters.

Uses the [`::group` workflow command](https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#grouping-log-lines) to group the results instead of printing ASCII delimiters.
@gaurav-nelson gaurav-nelson self-requested a review August 19, 2021 00:31
@gaurav-nelson
Copy link
Owner

Thank you @michamos for this PR.

I agree with you that it looks neat with groups. However, considering the usability, the change adds an extra click to view the results.

I might be opinionated, but I am happy to discuss how this improves existing output.

@gaurav-nelson gaurav-nelson added enhancement New feature or request question Further information is requested labels Aug 19, 2021
@michamos
Copy link
Author

For me the biggest issues in Github workflows output is having to scroll back to find the relevant content. I'd rather have a clear label and one extra click rather than a wall of text you need to precisely scroll into to find what you're looking for.

@gaurav-nelson
Copy link
Owner

@michamos
What if:

  1. we can group the other output you see under groups and leave the actual output out of groups? That way the actual output would be accecible without any clicks and you won't see other fluff?
  2. or may be add a configuration option and leave it as a choice so users can enable groups in output if they want.

I like the first option. Or something else you want to add.

@michamos
Copy link
Author

Indeed, the first option sounds great 👍 I think it would be best if you make the changes and group things in a way that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants