I did some work on the python implementation, if you like review/merge it. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * __init__.py in the folder, as I use it as a package/library * Let Exceptions propagate * Encapsulate all in a class, use Properties for result * Get IP before connecting to CLine, testing is done when calling Test() * Timeout is configurable by setting Timeout property (default 30s) * Measure Ping time * Some quick cleanups
|
Attention: as i encapsulated it all in a class there is a new syntax. See Main.py |
gavazquez
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I did some work on the python implementation, maybe you want to use some of it.
https://github.com/LaggAt/CLineTester/tree/master/Python
I did:
Will probably use it in another project, no Idea if I can put it on GitHub.
Kind regards,
Florian.