Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out using gcc9 #230

Closed
wants to merge 3 commits into from
Closed

Try out using gcc9 #230

wants to merge 3 commits into from

Conversation

mjcarroll
Copy link
Contributor

Attempting gcc9 via gazebo-tooling/action-gz-ci#50

This includes moving LocalCache into internal headers

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #230 (05fefff) into main (c47d85f) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 05fefff differs from pull request most recent head 6d4247d. Consider uploading reports for the commit 6d4247d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   75.55%   75.65%   +0.10%     
==========================================
  Files          20       20              
  Lines        2757     2748       -9     
==========================================
- Hits         2083     2079       -4     
+ Misses        674      669       -5     
Impacted Files Coverage Δ
src/FuelClient.cc 66.16% <ø> (+0.26%) ⬆️
src/LocalCache.cc 79.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47d85f...6d4247d. Read the comment docs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll changed the base branch from fuel_tools8_deprecations to main February 2, 2022 23:57
@mjcarroll mjcarroll closed this Feb 3, 2022
Core development automation moved this from Inbox to Done Feb 3, 2022
@mjcarroll mjcarroll deleted the focal_gcc9 branch February 3, 2022 20:09
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant