Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tapEither #1864

Merged
merged 1 commit into from May 16, 2023
Merged

feat: tapEither #1864

merged 1 commit into from May 16, 2023

Conversation

sukovanej
Copy link
Contributor

@sukovanej sukovanej force-pushed the feat/tapEither branch 4 times, most recently from 85a0533 to 53a0ed2 Compare May 15, 2023 18:33
@sukovanej sukovanej mentioned this pull request May 15, 2023
Open
@sukovanej sukovanej force-pushed the feat/tapEither branch 2 times, most recently from a9b945b to 93ac4e6 Compare May 15, 2023 21:26
@gcanti
Copy link
Owner

gcanti commented May 16, 2023

@sukovanej just one thing, for now I would keep the tapEither helper (in FromEither.ts) internal (as I did with Chain.tap for example) and postpone the decision on whether expose those helpers or not

@gcanti gcanti merged commit 0970869 into gcanti:master May 16, 2023
1 check passed
@gcanti gcanti added this to the 2.16 milestone May 17, 2023
renovate bot added a commit to valora-inc/wallet that referenced this pull request Aug 25, 2023
@renovate
fix(deps): update dependency fp-ts to v2.16.1 (#4121)
7485b8e 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fp-ts](https://togithub.com/gcanti/fp-ts) | [`2.13.1` ->
`2.16.1`](https://renovatebot.com/diffs/npm/fp-ts/2.13.1/2.16.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fp-ts/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fp-ts/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fp-ts/2.13.1/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fp-ts/2.13.1/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>gcanti/fp-ts (fp-ts)</summary>

###
[`v2.16.1`](https://togithub.com/gcanti/fp-ts/blob/HEAD/CHANGELOG.md#2161)

[Compare
Source](https://togithub.com/gcanti/fp-ts/compare/2.16.0...01b8661f2fa594d6f2010573f010d358e6808d13)

**Bug Fix**

- fix type signature of `ReaderTaskEither.tapReaderIO`,
[#&#8203;1895](https://togithub.com/gcanti/fp-ts/issues/1895)

###
[`v2.16.0`](https://togithub.com/gcanti/fp-ts/blob/HEAD/CHANGELOG.md#2160)

[Compare
Source](https://togithub.com/gcanti/fp-ts/compare/2.15.0...2.16.0)

- `tapEither` (dual) (aka `chainFirstEitherK` / `chainFirstEitherKW`)
[gcanti/fp-ts#1864
- `tapIO` (dual) (aka `chainFirstIOK`)
[gcanti/fp-ts#1865
- `as` / `asUnit`
[gcanti/fp-ts#1867
- `tapTask` (dual) (aka `chainFirstTaskK`)
[gcanti/fp-ts#1869
- `mapError` (dual) (aka `mapLeft`)
[gcanti/fp-ts#1870
- `mapBoth` (dual) (aka `bimap`)
[gcanti/fp-ts#1872
- `tapReader` (dual) (aka `chainFirstReaderK` / `chainFirstIReaderKW`)
[gcanti/fp-ts#1871
- `tapReaderEither` (dual) (aka `chainFirstReaderEitherK` /
`chainFirstEitherKW`)
[gcanti/fp-ts#1873
- `tapReaderIO` (dual) (aka `chainFirstReaderIOK`)
[gcanti/fp-ts#1873
- `tapReaderTask` (dual) (aka `chainFirstReaderTaskK`)
[gcanti/fp-ts#1873
- `tapTaskEither` (dual) (aka `chainFirstTaskEitherK` /
`chainFirstTaskEitherKW`)
[gcanti/fp-ts#1873
- `flatMapReaderTask` (dual) (aka `chainReaderTaskK` /
`chainReaderTaskKW`)
[gcanti/fp-ts#1874
- `flatMapTaskEither` (dual) (aka `chainTaskEitherK` /
`chainTaskEitherKW`)
[gcanti/fp-ts#1874
- `flatMapIO` (dual) (aka `chainIOK`)
[gcanti/fp-ts#1874
- `Option.orElse` (dual) (aka `alt` / `altW`)
[gcanti/fp-ts#1868
- `flatMapTask` (dual) (aka `chainTaskK`)
[gcanti/fp-ts#1876
- `flatMapReader` (dual) (aka `chainReaderK` / `chainReaderKW`)
[gcanti/fp-ts#1876
- `flatMapReaderIO` (dual) (aka `chainReaderIOK` / `chainReaderIOKW`)
[gcanti/fp-ts#1879
- `flatMap*` (aka `chain*K` / `chain*KW`)
[gcanti/fp-ts#1880

###
[`v2.15.0`](https://togithub.com/gcanti/fp-ts/blob/HEAD/CHANGELOG.md#2150)

[Compare
Source](https://togithub.com/gcanti/fp-ts/compare/2.14.0...2.15.0)

**New Feature**

-   `function`
    -   add `LazyArg`
-   add `tap` to
    -   `Either`
    -   `IO`
    -   `IOEither`
    -   `IOOption`
    -   `Option`
    -   `Reader`
    -   `ReaderEither`
    -   `ReaderIO`
    -   `ReaderTask`
    -   `ReaderTaskEither`
    -   `State`
    -   `StateReaderTaskEither`
    -   `Task`
    -   `TaskEither`
    -   `TaskOption`
-   add `flatMapNullable` (dual) to
    -   `Either`
    -   `IOEither`
    -   `ReaderEither`
    -   `ReaderTaskEither`
    -   `StateReaderTaskEither`
    -   `TaskEither`
-   add `flatMapOption` (dual) to
    -   `Either`
    -   `IOEither`
    -   `ReaderEither`
    -   `ReaderTaskEither`
    -   `StateReaderTaskEither`
    -   `TaskEither`
-   add `liftNullable` to
    -   `Either`
    -   `IOEither`
    -   `ReaderEither`
    -   `ReaderTaskEither`
    -   `StateReaderTaskEither`
    -   `TaskEither`
-   add `liftOption` to
    -   `Either`
    -   `IOEither`
    -   `ReaderEither`
    -   `ReaderTaskEither`
    -   `StateReaderTaskEither`
    -   `TaskEither`
-   add `flatMapEither` (dual) to
    -   `IOEither`
    -   `ReaderEither`
    -   `ReaderTaskEither`
    -   `TaskEither`
-   `Array`
    -   add index to `flatMap`
-   `NonEmptyArray`
    -   add index to `flatMap`
-   `ReadonlyArray`
    -   add index to `flatMap`
-   `ReadonlyNonEmptyArray`
    -   add index to `flatMap`

###
[`v2.14.0`](https://togithub.com/gcanti/fp-ts/blob/HEAD/CHANGELOG.md#2140)

[Compare
Source](https://togithub.com/gcanti/fp-ts/compare/2.13.2...2.14.0)

**New Feature**

-   add `flatMap` to
    -   `Either`
    -   `IOEither`
    -   `Reader`
    -   `ReaderEither`
    -   `ReaderIO`
    -   `ReaderTask`
    -   `ReaderTaskEither`
    -   `StateReaderTaskEither`
    -   `TaskEither`
    -   `NonEmptyArray`
    -   `ReadonlyNonEmptyArray`
    -   `Tree`
    -   `Array`
    -   `Identity`
    -   `IO`
    -   `IOOption`
    -   `Option`
    -   `ReadonlyArray`
    -   `State`
    -   `Task`
    -   `TaskOption`

###
[`v2.13.2`](https://togithub.com/gcanti/fp-ts/blob/HEAD/CHANGELOG.md#2132)

[Compare
Source](https://togithub.com/gcanti/fp-ts/compare/2.13.1...2.13.2)

- add `chainOptionKW`,
[#&#8203;1846](https://togithub.com/gcanti/fp-ts/issues/1846)
([@&#8203;DenisFrezzato](https://togithub.com/DenisFrezzato))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcanti gcanti gcanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sukovanej @gcanti