Et data

[jrmodel]

use the updated version

[codecov-commenter]

Codecov Report

Base: 69.47% // Head: 69.47% // No change to project coverage 👍

Coverage data is based on head (cdf9820) compared to base (4b84ff4).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files          36       36           
  Lines        4282     4282           
=======================================
  Hits         2975     2975           
  Misses       1307     1307           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[khufkens]

Hi @stineb, should this be integrated now or how do we go about this. There don't seem to be any breaking changes (tests still pass - if not adjusted).

[stineb]

It's not clear to me what is new in the branch jrmodel:ET_data (looking at this).

Whether to merge this or not depends on what we want to have in the rsofun documentation paper. If we keep the scope of that to using GPP and a "trait" (Vcmax) as calibration targets, then we should keep all ET-related developments out of the master branch for now. Therefore, I would not merge this now if it adds anything ET-related (but then, I can't see anything ET-related in commits to this branch).

[khufkens]

Fine with me. Will keep this open. @jrmodel keep your fork in sync (see sync button) to make this easier upstream if other changes to the main branch.

[jrmodel]

Fine with me. Will keep this open. @jrmodel keep your fork in sync (see sync button) to make this easier upstream if other changes to the main branch.

[jrmodel]

Ok. Fine